Fix tests

Author: alanpoulain

tests/GraphQl/Resolver/Stage/SecurityPostDenormalizeStageTest.php

@@ -118,25 +118,31 @@ public function testNotGranted(): void
 
     public function testNoSecurityBundleInstalled(): void
     {
+        $this->securityPostDenormalizeStage = new SecurityPostDenormalizeStage($this->resourceMetadataFactoryProphecy->reveal(), null);
+
         $operationName = 'item_query';
         $resourceClass = 'myResource';
         $isGranted = 'not_granted';
-        $extraVariables = ['extra' => false];
-        $resourceMetadata = (new ResourceMetadata())->withGraphql(
-            [
-                $operationName => ['security_post_denormalize' => $isGranted],
-            ]
-        );
+        $resourceMetadata = (new ResourceMetadata())->withGraphql([
+            $operationName => ['security_post_denormalize' => $isGranted],
+        ]);
         $this->resourceMetadataFactoryProphecy->create($resourceClass)->willReturn($resourceMetadata);
 
+        $this->expectException(\LogicException::class);
+
+        ($this->securityPostDenormalizeStage)($resourceClass, 'item_query', []);
+    }
+
+    public function testNoSecurityBundleInstalledNoExpression(): void
+    {
         $this->securityPostDenormalizeStage = new SecurityPostDenormalizeStage($this->resourceMetadataFactoryProphecy->reveal(), null);
 
-        $info = $this->prophesize(ResolveInfo::class)->reveal();
-        $this->expectException(\LogicException::class);
+        $resourceClass = 'myResource';
+        $resourceMetadata = new ResourceMetadata();
+        $this->resourceMetadataFactoryProphecy->create($resourceClass)->willReturn($resourceMetadata);
 
-        ($this->securityPostDenormalizeStage)($resourceClass,'item_query', [
-            'info' => $info,
-            'extra_variables' => $extraVariables,
-        ]);
+        $this->resourceAccessCheckerProphecy->isGranted(Argument::any())->shouldNotBeCalled();
+
+        ($this->securityPostDenormalizeStage)($resourceClass, 'item_query', []);
     }
 }

tests/GraphQl/Resolver/Stage/SecurityStageTest.php

@@ -104,16 +104,26 @@ public function testNoSecurityBundleInstalled(): void
         $operationName = 'item_query';
         $resourceClass = 'myResource';
         $isGranted = 'not_granted';
-        $extraVariables = ['extra' => false];
         $resourceMetadata = (new ResourceMetadata())->withGraphql([
             $operationName => ['security' => $isGranted],
         ]);
         $this->resourceMetadataFactoryProphecy->create($resourceClass)->willReturn($resourceMetadata);
 
         $this->expectException(\LogicException::class);
 
-        ($this->securityStage)($resourceClass, 'item_query', [
-            'extra_variables' => $extraVariables
-        ]);
+        ($this->securityStage)($resourceClass, 'item_query', []);
+    }
+
+    public function testNoSecurityBundleInstalledNoExpression(): void
+    {
+        $this->securityStage = new SecurityStage($this->resourceMetadataFactoryProphecy->reveal(), null);
+
+        $resourceClass = 'myResource';
+        $resourceMetadata = new ResourceMetadata();
+        $this->resourceMetadataFactoryProphecy->create($resourceClass)->willReturn($resourceMetadata);
+
+        $this->resourceAccessCheckerProphecy->isGranted(Argument::any())->shouldNotBeCalled();
+
+        ($this->securityStage)($resourceClass, 'item_query', []);
     }
 }