Fix review

Author: vincentchalamon

features/graphql/non_resource.feature

@@ -0,0 +1,92 @@
+# TODO: FIXME: GraphQL support for non-resources is non-existent
+
+Feature: GraphQL non-resource handling
+  In order to use non-resource types
+  As a developer
+  I should be able to serialize types not mapped to an API resource.
+
+  Scenario: Get a resource containing a raw object
+    Then it is not supported
+#     When I send the following GraphQL request:
+#     """
+#     {
+#       containNonResource(id: "/contain_non_resources/1") {
+#         _id
+#         id
+#         nested {
+#           _id
+#           id
+#           notAResource {
+#             foo
+#             bar
+#           }
+#         }
+#         notAResource {
+#           foo
+#           bar
+#         }
+#       }
+#     }
+#     """
+#     Then the response status code should be 200
+#     And the response should be in JSON
+#     And the header "Content-Type" should be equal to "application/json"
+#     And the JSON should be equal to:
+#     """
+#     {
+#       "data": {
+#         "containNonResource": {
+#           "_id": 1,
+#           "id": "/contain_non_resources/1",
+#           "nested": {
+#               "_id": "1-nested",
+#               "id": "/contain_non_resources/1-nested",
+#               "notAResource": {
+#                   "foo": "f2",
+#                   "bar": "b2"
+#               }
+#           },
+#           "notAResource": {
+#               "foo": "f1",
+#               "bar": "b1"
+#           }
+#         }
+#       }
+#     }
+#     """
+
+  @!mongodb
+  @createSchema
+  Scenario: Create a resource that has a non-resource relation.
+    Then it is not supported
+#     When I send the following GraphQL request:
+#     """
+#     mutation {
+#       createNonRelationResource(input: {relation: {foo: "test"}}) {
+#         nonRelationResource {
+#           _id
+#           id
+#           relation {
+#             foo
+#           }
+#         }
+#       }
+#     }
+#     """
+#     Then the response status code should be 200
+#     And the response should be in JSON
+#     And the header "Content-Type" should be equal to "application/json"
+#     And the JSON should be equal to:
+#     """
+#     {
+#       "data": {
+#         "nonRelationResource": {
+#           "_id": 1,
+#           "id": "/non_relation_resources/1",
+#           "relation": {
+#             "foo": "test"
+#           }
+#         }
+#       }
+#     }
+#     """

features/main/table_inheritance.feature

@@ -351,47 +351,7 @@ Feature: Table inheritance
     }
     """
 
-  @createSchema
-  Scenario: Create a table inherited resource
-    When I add "Content-Type" header equal to "application/ld+json"
-    And I send a "POST" request to "/dummy_table_inheritance_children" with body:
-    """
-    {"name": "foo", "nickname": "bar"}
-    """
-    Then the response status code should be 201
-    And the response should be in JSON
-    And the header "Content-Type" should be equal to "application/ld+json; charset=utf-8"
-    And the JSON should be valid according to this schema:
-    """
-    {
-      "type": "object",
-      "properties": {
-        "@type": {
-          "type": "string",
-          "pattern": "^DummyTableInheritanceChild$"
-        },
-        "@context": {
-          "type": "string",
-          "pattern": "^/contexts/DummyTableInheritanceChild$"
-        },
-        "@id": {
-          "type": "string",
-          "pattern": "^/dummy_table_inheritance_children/1$"
-        },
-        "name": {
-          "type": "string",
-          "pattern": "^foo$",
-          "required": "true"
-        },
-        "nickname": {
-          "type": "string",
-          "pattern": "^bar$",
-          "required": "true"
-        }
-      }
-    }
-    """
-
+  @!mongodb
   @createSchema
   @dropSchema
   Scenario: Generate iri from parent resource
@@ -435,7 +395,7 @@ Feature: Table inheritance
               },
               "owner": {
                 "type": "string",
-                "pattern": "^/people/\\d+$",
+                "pattern": "^/custom_users/\\d+$",
                 "required": "true"
               }
             }
@@ -448,6 +408,7 @@ Feature: Table inheritance
     }
     """
 
+  @!mongodb
   @createSchema
   Scenario: Generate iri from current resource even if parent class is a resource
     Given there are 3 sites with external owner

src/Bridge/Symfony/Routing/RouteNameResolver.php

@@ -66,7 +66,7 @@ public function getRouteName(string $resourceClass, $operationType /*, array $co
             $operation = $route->getDefault(sprintf('_api_%s_operation_name', $operationType));
             $methods = $route->getMethods();
 
-            if (null !== $currentResourceClass && is_a($resourceClass, $currentResourceClass, true) && null !== $operation && (empty($methods) || \in_array('GET', $methods, true))) {
+            if (null !== $operation && (empty($methods) || \in_array('GET', $methods, true)) && null !== $currentResourceClass && is_a($resourceClass, $currentResourceClass, true)) {
                 if (OperationType::SUBRESOURCE === $operationType && false === $this->isSameSubresource($context, $route->getDefault('_api_subresource_context'))) {
                     continue;
                 }

tests/Fixtures/TestBundle/Entity/AbstractUser.php

@@ -21,10 +21,10 @@
  * @ORM\InheritanceType("JOINED")
  * @ApiResource(
  *     collectionOperations={
- *         "get"={"path"="/people"}
+ *         "get"={"path"="/custom_users"}
  *     },
  *     itemOperations={
- *         "get"={"path"="/people/{id}"}
+ *         "get"={"path"="/custom_users/{id}"}
  *     }
  * )
  */