Rolling back to mapping unknown object types as JSON-Schema {"type": "string"}

To avoid BC breaks, we defer this fix to #3403

> **API Platform version(s) affected**: 2.5.x
>
> **Description**
>
> In our tests for `TypeFactory`:
>
> ```
>
>         yield [['type' => 'string'], new Type(Type::BUILTIN_TYPE_OBJECT)];
>         yield [['type' => 'string'], new Type(Type::BUILTIN_TYPE_OBJECT, true)];
>
> // ...
>
>         yield [['type' => 'string'], new Type(Type::BUILTIN_TYPE_OBJECT, false, Dummy::class)];
>         yield [['type' => 'string'], new Type(Type::BUILTIN_TYPE_OBJECT, true, Dummy::class)];
> ```
>
> While reviewing #3402, @dunglas found a potential BC break with objects that may be used in URIs as `string`s (therefore not `objects`):
>
>     * [#3402 (comment)](#3402 (comment))
>
>     * [#3402 (comment)](#3402 (comment))
>
>
> **How to reproduce**
>
> The test should instead convert `object` to `object`:
>
> ```
>
>         yield [['type' => 'object'], new Type(Type::BUILTIN_TYPE_OBJECT)];
>         yield [['type' => 'object'], new Type(Type::BUILTIN_TYPE_OBJECT, true)];
>
> // ...
>
>         yield [['type' => 'object'], new Type(Type::BUILTIN_TYPE_OBJECT, false, Dummy::class)];
>         yield [['type' => 'object'], new Type(Type::BUILTIN_TYPE_OBJECT, true, Dummy::class)];
> ```

Author: Ocramius

src/JsonSchema/TypeFactory.php

@@ -117,7 +117,7 @@ private function makeBasicType(Type $type, string $format = 'json', ?bool $reada
     private function getClassType(?string $className, string $format, ?bool $readableLink, ?array $serializerContext, ?Schema $schema): array
     {
         if (null === $className) {
-            return ['type' => 'object'];
+            return ['type' => 'string'];
         }
 
         if (is_a($className, \DateTimeInterface::class, true)) {
@@ -141,7 +141,7 @@ private function getClassType(?string $className, string $format, ?bool $readabl
 
         // Skip if $schema is null (filters only support basic types)
         if (null === $schema) {
-            return ['type' => 'object'];
+            return ['type' => 'string'];
         }
 
         if ($this->isResourceClass($className) && true !== $readableLink) {

tests/JsonSchema/TypeFactoryTest.php

@@ -42,13 +42,13 @@ public function typeProvider(): iterable
         yield [['nullable' => true, 'type' => 'boolean'], new Type(Type::BUILTIN_TYPE_BOOL, true)];
         yield [['type' => 'string'], new Type(Type::BUILTIN_TYPE_STRING)];
         yield [['nullable' => true, 'type' => 'string'], new Type(Type::BUILTIN_TYPE_STRING, true)];
-        yield [['type' => 'object'], new Type(Type::BUILTIN_TYPE_OBJECT)];
-        yield [['nullable' => true, 'type' => 'object'], new Type(Type::BUILTIN_TYPE_OBJECT, true)];
+        yield [['type' => 'string'], new Type(Type::BUILTIN_TYPE_OBJECT)];
+        yield [['nullable' => true, 'type' => 'string'], new Type(Type::BUILTIN_TYPE_OBJECT, true)];
         yield [['type' => 'string', 'format' => 'date-time'], new Type(Type::BUILTIN_TYPE_OBJECT, false, \DateTimeImmutable::class)];
         yield [['nullable' => true, 'type' => 'string', 'format' => 'date-time'], new Type(Type::BUILTIN_TYPE_OBJECT, true, \DateTimeImmutable::class)];
         yield [['type' => 'string', 'format' => 'duration'], new Type(Type::BUILTIN_TYPE_OBJECT, false, \DateInterval::class)];
-        yield [['type' => 'object'], new Type(Type::BUILTIN_TYPE_OBJECT, false, Dummy::class)];
-        yield [['nullable' => true, 'type' => 'object'], new Type(Type::BUILTIN_TYPE_OBJECT, true, Dummy::class)];
+        yield [['type' => 'string'], new Type(Type::BUILTIN_TYPE_OBJECT, false, Dummy::class)];
+        yield [['nullable' => true, 'type' => 'string'], new Type(Type::BUILTIN_TYPE_OBJECT, true, Dummy::class)];
         yield [['type' => 'array', 'items' => ['type' => 'string']], new Type(Type::BUILTIN_TYPE_STRING, false, null, true)];
         yield 'array can be itself nullable' => [
             ['nullable' => true, 'type' => 'array', 'items' => ['type' => 'string']],
@@ -160,13 +160,13 @@ public function openAPIV2typeProvider(): iterable
         yield [['type' => 'boolean'], new Type(Type::BUILTIN_TYPE_BOOL, true)];
         yield [['type' => 'string'], new Type(Type::BUILTIN_TYPE_STRING)];
         yield [['type' => 'string'], new Type(Type::BUILTIN_TYPE_STRING, true)];
-        yield [['type' => 'object'], new Type(Type::BUILTIN_TYPE_OBJECT)];
-        yield [['type' => 'object'], new Type(Type::BUILTIN_TYPE_OBJECT, true)];
+        yield [['type' => 'string'], new Type(Type::BUILTIN_TYPE_OBJECT)];
+        yield [['type' => 'string'], new Type(Type::BUILTIN_TYPE_OBJECT, true)];
         yield [['type' => 'string', 'format' => 'date-time'], new Type(Type::BUILTIN_TYPE_OBJECT, false, \DateTimeImmutable::class)];
         yield [['type' => 'string', 'format' => 'date-time'], new Type(Type::BUILTIN_TYPE_OBJECT, true, \DateTimeImmutable::class)];
         yield [['type' => 'string', 'format' => 'duration'], new Type(Type::BUILTIN_TYPE_OBJECT, false, \DateInterval::class)];
-        yield [['type' => 'object'], new Type(Type::BUILTIN_TYPE_OBJECT, false, Dummy::class)];
-        yield [['type' => 'object'], new Type(Type::BUILTIN_TYPE_OBJECT, true, Dummy::class)];
+        yield [['type' => 'string'], new Type(Type::BUILTIN_TYPE_OBJECT, false, Dummy::class)];
+        yield [['type' => 'string'], new Type(Type::BUILTIN_TYPE_OBJECT, true, Dummy::class)];
         yield [['type' => 'array', 'items' => ['type' => 'string']], new Type(Type::BUILTIN_TYPE_STRING, false, null, true)];
         yield 'array can be itself nullable, but ignored in OpenAPI V2' => [
             ['type' => 'array', 'items' => ['type' => 'string']],