changing error format to follow graphql spec

Author: mahmoodbazdar

features/graphql/authorization.feature

@@ -18,7 +18,7 @@ Feature: Authorization checking
     Then the response status code should be 200
     And the response should be in JSON
     And the header "Content-Type" should be equal to "application/json"
-    And the JSON node "errors[0].status" should be equal to 403
+    And the JSON node "errors[0].extensions.status" should be equal to 403
     And the JSON node "errors[0].extensions.category" should be equal to user
     And the JSON node "errors[0].message" should be equal to "Access Denied."
 
@@ -40,7 +40,7 @@ Feature: Authorization checking
     Then the response status code should be 200
     And the response should be in JSON
     And the header "Content-Type" should be equal to "application/json"
-    And the JSON node "errors[0].status" should be equal to 403
+    And the JSON node "errors[0].extensions.status" should be equal to 403
     And the JSON node "errors[0].extensions.category" should be equal to user
     And the JSON node "errors[0].message" should be equal to "Access Denied."
 
@@ -83,7 +83,7 @@ Feature: Authorization checking
     And the response should be in JSON
     And the header "Content-Type" should be equal to "application/json"
     And the JSON node "data.securedDummies" should be null
-    And the JSON node "errors[0].status" should be equal to 403
+    And the JSON node "errors[0].extensions.status" should be equal to 403
     And the JSON node "errors[0].extensions.category" should be equal to user
     And the JSON node "errors[0].message" should be equal to "Access Denied."
 
@@ -102,7 +102,7 @@ Feature: Authorization checking
     Then the response status code should be 200
     And the response should be in JSON
     And the header "Content-Type" should be equal to "application/json"
-    And the JSON node "errors[0].status" should be equal to 403
+    And the JSON node "errors[0].extensions.status" should be equal to 403
     And the JSON node "errors[0].extensions.category" should be equal to user
     And the JSON node "errors[0].message" should be equal to "Only admins can create a secured dummy."
 
@@ -159,7 +159,7 @@ Feature: Authorization checking
     Then the response status code should be 200
     And the response should be in JSON
     And the header "Content-Type" should be equal to "application/json"
-    And the JSON node "errors[0].status" should be equal to 403
+    And the JSON node "errors[0].extensions.status" should be equal to 403
     And the JSON node "errors[0].extensions.category" should be equal to user
     And the JSON node "errors[0].message" should be equal to "Access Denied."
 
@@ -196,7 +196,7 @@ Feature: Authorization checking
     Then the response status code should be 200
     And the response should be in JSON
     And the header "Content-Type" should be equal to "application/json"
-    And the JSON node "errors[0].status" should be equal to 403
+    And the JSON node "errors[0].extensions.status" should be equal to 403
     And the JSON node "errors[0].extensions.category" should be equal to user
     And the JSON node "errors[0].message" should be equal to "Access Denied."
 

features/graphql/introspection.feature

@@ -6,7 +6,7 @@ Feature: GraphQL introspection support
     Then the response status code should be 200
     And the response should be in JSON
     And the header "Content-Type" should be equal to "application/json"
-    And the JSON node "errors[0].status" should be equal to 400
+    And the JSON node "errors[0].extensions.status" should be equal to 400
     And the JSON node "errors[0].extensions.category" should be equal to user
     And the JSON node "errors[0].message" should be equal to "GraphQL query is not valid."
 

features/graphql/mutation.feature

@@ -674,11 +674,11 @@ Feature: GraphQL mutation support
     Then the response status code should be 200
     And the response should be in JSON
     And the header "Content-Type" should be equal to "application/json"
-    And the JSON node "errors[0].status" should be equal to "400"
+    And the JSON node "errors[0].extensions.status" should be equal to "400"
     And the JSON node "errors[0].message" should be equal to "name: This value should not be blank."
-    And the JSON node "errors[0].violations" should exist
-    And the JSON node "errors[0].violations[0].path" should be equal to "name"
-    And the JSON node "errors[0].violations[0].message" should be equal to "This value should not be blank."
+    And the JSON node "errors[0].extensions.violations" should exist
+    And the JSON node "errors[0].extensions.violations[0].path" should be equal to "name"
+    And the JSON node "errors[0].extensions.violations[0].message" should be equal to "This value should not be blank."
 
   Scenario: Execute a custom mutation
     Given there are 1 dummyCustomMutation objects

src/GraphQl/Serializer/Exception/HttpExceptionNormalizer.php

@@ -36,7 +36,7 @@ public function normalize($object, $format = null, array $context = []): array
         $httpException = $object->getPrevious();
         $error = FormattedError::createFromException($object);
         $error['message'] = $httpException->getMessage();
-        $error['status'] = $statusCode = $httpException->getStatusCode();
+        $error['extensions']['status'] = $statusCode = $httpException->getStatusCode();
         $error['extensions']['category'] = $statusCode < 500 ? 'user' : Error::CATEGORY_INTERNAL;
 
         return $error;

src/GraphQl/Serializer/Exception/ValidationExceptionNormalizer.php

@@ -39,13 +39,13 @@ public function normalize($object, $format = null, array $context = []): array
         $validationException = $object->getPrevious();
         $error = FormattedError::createFromException($object);
         $error['message'] = $validationException->getMessage();
-        $error['status'] = Response::HTTP_BAD_REQUEST;
+        $error['extensions']['status'] = Response::HTTP_BAD_REQUEST;
         $error['extensions']['category'] = 'user';
-        $error['violations'] = [];
+        $error['extensions']['violations'] = [];
 
         /** @var ConstraintViolation $violation */
         foreach ($validationException->getConstraintViolationList() as $violation) {
-            $error['violations'][] = [
+            $error['extensions']['violations'][] = [
                 'path' => $violation->getPropertyPath(),
                 'message' => $violation->getMessage(),
             ];

tests/GraphQl/Serializer/Exception/HttpExceptionNormalizerTest.php

@@ -46,7 +46,7 @@ public function testNormalize(HttpException $exception, string $expectedExceptio
 
         $normalizedError = $this->httpExceptionNormalizer->normalize($error);
         $this->assertSame($expectedExceptionMessage, $normalizedError['message']);
-        $this->assertSame($expectedStatus, $normalizedError['status']);
+        $this->assertSame($expectedStatus, $normalizedError['extensions']['status']);
         $this->assertSame($expectedCategory, $normalizedError['extensions']['category']);
     }
 

tests/GraphQl/Serializer/Exception/ValidationExceptionNormalizerTest.php

@@ -48,9 +48,9 @@ public function testNormalize(): void
 
         $normalizedError = $this->validationExceptionNormalizer->normalize($error);
         $this->assertSame($exceptionMessage, $normalizedError['message']);
-        $this->assertSame(400, $normalizedError['status']);
+        $this->assertSame(400, $normalizedError['extensions']['status']);
         $this->assertSame('user', $normalizedError['extensions']['category']);
-        $this->assertArrayHasKey('violations', $normalizedError);
+        $this->assertArrayHasKey('violations', $normalizedError['extensions']);
         $this->assertSame([
             [
                 'path' => 'field 1',
@@ -60,7 +60,7 @@ public function testNormalize(): void
                 'path' => 'field 2',
                 'message' => 'message 2',
             ],
-        ], $normalizedError['violations']);
+        ], $normalizedError['extensions']['violations']);
     }
 
     public function testSupportsNormalization(): void