Add "static_lambda" CS rule

phansys · phansys · commit 0c89e06751ab · 2020-09-15T10:51:52.000-03:00
diff --git a/.php_cs.dist b/.php_cs.dist
@@ -100,6 +100,7 @@ return PhpCsFixer\Config::create()
         'phpdoc_trim_consecutive_blank_line_separation' => true,
         'phpdoc_var_annotation_correct_order' => true,
         'return_assignment' => true,
+        'static_lambda' => true,
         'strict_param' => true,
         'visibility_required' => [
             'elements' => [
diff --git a/src/Bridge/Doctrine/MongoDbOdm/Filter/OrderFilter.php b/src/Bridge/Doctrine/MongoDbOdm/Filter/OrderFilter.php
@@ -43,7 +43,7 @@ final class OrderFilter extends AbstractFilter implements OrderFilterInterface
     public function __construct(ManagerRegistry $managerRegistry, string $orderParameterName = 'order', LoggerInterface $logger = null, array $properties = null, NameConverterInterface $nameConverter = null)
     {
         if (null !== $properties) {
-            $properties = array_map(function ($propertyOptions) {
+            $properties = array_map(static function ($propertyOptions) {
                 // shorthand for default direction
                 if (\is_string($propertyOptions)) {
                     $propertyOptions = [
diff --git a/src/Bridge/Doctrine/MongoDbOdm/SubresourceDataProvider.php b/src/Bridge/Doctrine/MongoDbOdm/SubresourceDataProvider.php
@@ -164,8 +164,8 @@ private function buildAggregation(array $identifiers, array $context, array $exe
         $aggregation = $this->buildAggregation($identifiers, $context, $executeOptions, $aggregation, --$remainingIdentifiers, $topAggregationBuilder);
 
         $results = $aggregation->execute($executeOptions)->toArray();
-        $in = array_reduce($results, function ($in, $result) use ($previousAssociationProperty) {
-            return $in + array_map(function ($result) {
+        $in = array_reduce($results, static function ($in, $result) use ($previousAssociationProperty) {
+            return $in + array_map(static function ($result) {
                 return $result['_id'];
             }, $result[$previousAssociationProperty] ?? []);
         }, []);
diff --git a/src/Bridge/Doctrine/Orm/Filter/OrderFilter.php b/src/Bridge/Doctrine/Orm/Filter/OrderFilter.php
@@ -44,7 +44,7 @@ class OrderFilter extends AbstractContextAwareFilter implements OrderFilterInter
     public function __construct(ManagerRegistry $managerRegistry, ?RequestStack $requestStack = null, string $orderParameterName = 'order', LoggerInterface $logger = null, array $properties = null, NameConverterInterface $nameConverter = null)
     {
         if (null !== $properties) {
-            $properties = array_map(function ($propertyOptions) {
+            $properties = array_map(static function ($propertyOptions) {
                 // shorthand for default direction
                 if (\is_string($propertyOptions)) {
                     $propertyOptions = [
diff --git a/src/Bridge/Symfony/Bundle/DependencyInjection/Configuration.php b/src/Bridge/Symfony/Bundle/DependencyInjection/Configuration.php
@@ -313,7 +313,7 @@ private function addSwaggerSection(ArrayNodeDefinition $rootNode): void
                                 })
                             ->end()
                             ->validate()
-                                ->ifTrue(function ($v) use ($defaultVersions) {
+                                ->ifTrue(static function ($v) use ($defaultVersions) {
                                     return $v !== array_intersect($v, $defaultVersions);
                                 })
                                 ->thenInvalid(sprintf('Only the versions %s are supported. Got %s.', implode(' and ', $defaultVersions), '%s'))
@@ -383,7 +383,7 @@ private function addHttpCacheSection(ArrayNodeDefinition $rootNode): void
                                 ->variableNode('request_options')
                                     ->defaultValue([])
                                     ->validate()
-                                        ->ifTrue(function ($v) { return false === \is_array($v); })
+                                        ->ifTrue(static function ($v) { return false === \is_array($v); })
                                         ->thenInvalid('The request_options parameter must be an array.')
                                     ->end()
                                     ->info('To pass options to the client charged with the request.')
@@ -481,7 +481,7 @@ private function addExceptionToStatusSection(ArrayNodeDefinition $rootNode): voi
                     ->useAttributeAsKey('exception_class')
                     ->beforeNormalization()
                         ->ifArray()
-                        ->then(function (array $exceptionToStatus) {
+                        ->then(static function (array $exceptionToStatus) {
                             foreach ($exceptionToStatus as &$httpStatusCode) {
                                 if (\is_int($httpStatusCode)) {
                                     continue;
@@ -500,7 +500,7 @@ private function addExceptionToStatusSection(ArrayNodeDefinition $rootNode): voi
                     ->prototype('integer')->end()
                     ->validate()
                         ->ifArray()
-                        ->then(function (array $exceptionToStatus) {
+                        ->then(static function (array $exceptionToStatus) {
                             foreach ($exceptionToStatus as $httpStatusCode) {
                                 if ($httpStatusCode < 100 || $httpStatusCode >= 600) {
                                     throw new InvalidConfigurationException(sprintf('The HTTP status code "%s" is not valid.', $httpStatusCode));
@@ -525,7 +525,7 @@ private function addFormatSection(ArrayNodeDefinition $rootNode, string $key, ar
                     ->useAttributeAsKey('format')
                     ->beforeNormalization()
                         ->ifArray()
-                        ->then(function ($v) {
+                        ->then(static function ($v) {
                             foreach ($v as $format => $value) {
                                 if (isset($value['mime_types'])) {
                                     continue;
diff --git a/src/GraphQl/Type/FieldsBuilder.php b/src/GraphQl/Type/FieldsBuilder.php
@@ -395,7 +395,7 @@ private function getFilterArgs(array $args, ?string $resourceClass, ?ResourceMet
                 if (\array_key_exists($key, $parsed) && \is_array($parsed[$key])) {
                     $parsed = [$key => ''];
                 }
-                array_walk_recursive($parsed, function (&$value) use ($graphqlFilterType) {
+                array_walk_recursive($parsed, static function (&$value) use ($graphqlFilterType) {
                     $value = $graphqlFilterType;
                 });
                 $args = $this->mergeFilterArgs($args, $parsed, $resourceMetadata, $key);
diff --git a/src/HttpCache/VarnishPurger.php b/src/HttpCache/VarnishPurger.php
@@ -82,7 +82,7 @@ public function purge(array $iris)
     private function purgeRequest(array $iris)
     {
         // Create the regex to purge all tags in just one request
-        $parts = array_map(function ($iri) {
+        $parts = array_map(static function ($iri) {
             return sprintf('(^|\,)%s($|\,)', preg_quote($iri));
         }, $iris);
 
diff --git a/src/Security/Core/Authorization/ExpressionLanguageProvider.php b/src/Security/Core/Authorization/ExpressionLanguageProvider.php
@@ -26,9 +26,9 @@ final class ExpressionLanguageProvider implements ExpressionFunctionProviderInte
     public function getFunctions(): array
     {
         return [
-            new ExpressionFunction('is_granted', function ($attributes, $object = 'null') {
+            new ExpressionFunction('is_granted', static function ($attributes, $object = 'null') {
                 return sprintf('$auth_checker->isGranted(%s, %s)', $attributes, $object);
-            }, function (array $variables, $attributes, $object = null) {
+            }, static function (array $variables, $attributes, $object = null) {
                 return $variables['auth_checker']->isGranted($attributes, $object);
             }),
         ];
diff --git a/src/Security/ExpressionLanguage.php b/src/Security/ExpressionLanguage.php
@@ -40,9 +40,9 @@ protected function registerFunctions()
     {
         parent::registerFunctions();
 
-        $this->register('is_granted', function ($attributes, $object = 'null') {
+        $this->register('is_granted', static function ($attributes, $object = 'null') {
             return sprintf('$auth_checker->isGranted(%s, %s)', $attributes, $object);
-        }, function (array $variables, $attributes, $object = null) {
+        }, static function (array $variables, $attributes, $object = null) {
             return $variables['auth_checker']->isGranted($attributes, $object);
         });
     }
diff --git a/src/Security/ResourceAccessChecker.php b/src/Security/ResourceAccessChecker.php
@@ -88,7 +88,7 @@ private function getEffectiveRoles(TokenInterface $token): array
             return $this->roleHierarchy->getReachableRoleNames($token->getRoleNames());
         }
 
-        return array_map(function (Role $role): string {
+        return array_map(static function (Role $role): string {
             return $role->getRole();
         }, $this->roleHierarchy->getReachableRoles($token->getRoles()));
     }
diff --git a/src/Util/RequestParser.php b/src/Util/RequestParser.php
@@ -55,7 +55,7 @@ public static function parseRequestParams(string $source): array
 
         $source = preg_replace_callback(
             '/(^|(?<=&))[^=[&]+/',
-            function ($key) {
+            static function ($key) {
                 return bin2hex(urldecode($key[0]));
             },
             $source

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ final class OrderFilter extends AbstractFilter implements OrderFilterInterface`
`43`	`43`	`public function __construct(ManagerRegistry $managerRegistry, string $orderParameterName = 'order', LoggerInterface $logger = null, array $properties = null, NameConverterInterface $nameConverter = null)`
`44`	`44`	`{`
`45`	`45`	`if (null !== $properties) {`
`46`		`- $properties = array_map(function ($propertyOptions) {`
	`46`	`+ $properties = array_map(static function ($propertyOptions) {`
`47`	`47`	`// shorthand for default direction`
`48`	`48`	`if (\is_string($propertyOptions)) {`
`49`	`49`	`$propertyOptions = [`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ class OrderFilter extends AbstractContextAwareFilter implements OrderFilterInter`
`44`	`44`	`public function __construct(ManagerRegistry $managerRegistry, ?RequestStack $requestStack = null, string $orderParameterName = 'order', LoggerInterface $logger = null, array $properties = null, NameConverterInterface $nameConverter = null)`
`45`	`45`	`{`
`46`	`46`	`if (null !== $properties) {`
`47`		`- $properties = array_map(function ($propertyOptions) {`
	`47`	`+ $properties = array_map(static function ($propertyOptions) {`
`48`	`48`	`// shorthand for default direction`
`49`	`49`	`if (\is_string($propertyOptions)) {`
`50`	`50`	`$propertyOptions = [`
Original file line number	Diff line number	Diff line change
`@@ -395,7 +395,7 @@ private function getFilterArgs(array $args, ?string $resourceClass, ?ResourceMet`
`395`	`395`	`if (\array_key_exists($key, $parsed) && \is_array($parsed[$key])) {`
`396`	`396`	`$parsed = [$key => ''];`
`397`	`397`	`}`
`398`		`- array_walk_recursive($parsed, function (&$value) use ($graphqlFilterType) {`
	`398`	`+ array_walk_recursive($parsed, static function (&$value) use ($graphqlFilterType) {`
`399`	`399`	`$value = $graphqlFilterType;`
`400`	`400`	`});`
`401`	`401`	`$args = $this->mergeFilterArgs($args, $parsed, $resourceMetadata, $key);`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ public function purge(array $iris)`
`82`	`82`	`private function purgeRequest(array $iris)`
`83`	`83`	`{`
`84`	`84`	`// Create the regex to purge all tags in just one request`
`85`		`- $parts = array_map(function ($iri) {`
	`85`	`+ $parts = array_map(static function ($iri) {`
`86`	`86`	`return sprintf('(^\|\,)%s($\|\,)', preg_quote($iri));`
`87`	`87`	`}, $iris);`
`88`	`88`
Original file line number	Diff line number	Diff line change
`@@ -40,9 +40,9 @@ protected function registerFunctions()`
`40`	`40`	`{`
`41`	`41`	`parent::registerFunctions();`
`42`	`42`
`43`		`- $this->register('is_granted', function ($attributes, $object = 'null') {`
	`43`	`+ $this->register('is_granted', static function ($attributes, $object = 'null') {`
`44`	`44`	`return sprintf('$auth_checker->isGranted(%s, %s)', $attributes, $object);`
`45`		`- }, function (array $variables, $attributes, $object = null) {`
	`45`	`+ }, static function (array $variables, $attributes, $object = null) {`
`46`	`46`	`return $variables['auth_checker']->isGranted($attributes, $object);`
`47`	`47`	`});`
`48`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ private function getEffectiveRoles(TokenInterface $token): array`
`88`	`88`	`return $this->roleHierarchy->getReachableRoleNames($token->getRoleNames());`
`89`	`89`	`}`
`90`	`90`
`91`		`- return array_map(function (Role $role): string {`
	`91`	`+ return array_map(static function (Role $role): string {`
`92`	`92`	`return $role->getRole();`
`93`	`93`	`}, $this->roleHierarchy->getReachableRoles($token->getRoles()));`
`94`	`94`	`}`