fix(ts/oxlint): enable tsconfig compilerOptions and oxlint rules

Author: J3m5

.oxlintrc.json

@@ -10,7 +10,8 @@
     "suspicious": "error"
   },
   "env": {
-    "browser": true
+    "es2022": true,
+    "shared-node-browser": true
   },
   "plugins": [
     "typescript",
@@ -30,7 +31,7 @@
     ],
     "@typescript-eslint/no-explicit-any": "off",
     "@typescript-eslint/no-unsafe-declaration-merging": "off",
-    "eslint/curly": "off",
+    "eslint/curly": "error",
     "eslint/max-depth": "off",
     "eslint/max-lines": "off",
     "eslint/max-lines-per-function": "off",
@@ -64,22 +65,15 @@
     "no-optional-chaining": "off",
     "no-ternary": "off",
     "no-undefined": "off",
-    "no-unexpected-multiline": "off",
     "oxc/no-barrel-file": "off",
     "oxc/no-rest-spread-properties": "off",
-    "prefer-promise-reject-errors": "off",
     "promise/catch-or-return": "off",
-    "promise/no-nesting": "off",
-    "promise/no-return-wrap": "off",
-    "promise/prefer-await-to-callbacks": "off",
-    "promise/prefer-await-to-then": "off",
     "sort-imports": "off",
     "sort-keys": "off",
     "sort-vars": "off",
     "typescript/consistent-indexed-object-style": "error",
     "typescript/explicit-function-return-type": "off",
     "typescript/no-empty-interface": "off",
-    "unicorn/empty-brace-spaces": "off",
     "unicorn/error-message": "off",
     "unicorn/filename-case": [
       "error",
@@ -102,9 +96,9 @@
         "withinDescribe": "test"
       }
     ],
-        "vitest/max-expects": "off",
-        "vitest/no-hooks": "off",
-        "vitest/prefer-lowercase-title": "off",
+    "vitest/max-expects": "off",
+    "vitest/no-hooks": "off",
+    "vitest/prefer-lowercase-title": "off",
     "vitest/prefer-strict-equal": "off",
     "vitest/prefer-to-be-falsy": "off",
     "vitest/prefer-to-be-truthy": "off",

src/graphql/parseGraphQl.ts

@@ -67,10 +67,9 @@ export default async function parseGraphQl(
       type.name !== schema.subscriptionType?.name &&
       !type.name.startsWith("__") &&
       // mutation
-      !type.name.startsWith(type.name[0].toLowerCase()) &&
+      (!type.name[0] || !type.name.startsWith(type.name[0].toLowerCase())) &&
       !type.name.endsWith("Connection") &&
-      !type.name.endsWith("Edge") &&
-      !type.name.endsWith("PageInfo"),
+      !type.name.endsWith("Edge"),
   ) as IntrospectionObjectType[];
 
   const resources: Resource[] = [];
@@ -84,7 +83,7 @@ export default async function parseGraphQl(
         range: getRangeFromGraphQlType(resourceFieldType.type),
         reference: getReferenceFromGraphQlType(resourceFieldType.type),
         required: resourceFieldType.type.kind === "NON_NULL",
-        description: resourceFieldType.description,
+        description: resourceFieldType.description || "",
         deprecated: resourceFieldType.isDeprecated,
       });
 

src/hydra/fetchJsonLd.ts

@@ -43,20 +43,21 @@ export default async function fetchJsonLd(
     throw reason;
   }
 
-  return response.json().then((body: JsonLd) => ({
+  const body = (await response.json()) as JsonLd;
+  return {
     response,
     body,
     document: body,
     documentUrl: url,
-  }));
+  };
 }
 
 function setHeaders(options: RequestInitExtended): RequestInit {
   if (!options.headers) {
     return { ...options, headers: {} };
   }
 
-  let headers: HeadersInit =
+  let headers =
     typeof options.headers === "function" ? options.headers() : options.headers;
 
   headers = new Headers(headers);

src/hydra/fetchResource.ts

@@ -1,24 +1,24 @@
-import type { EmptyResponseDocument, ResponseDocument } from "./fetchJsonLd.js";
 import fetchJsonLd from "./fetchJsonLd.js";
 import type { IriTemplateMapping, RequestInitExtended } from "./types.js";
 
-export default function fetchResource(
+export default async function fetchResource(
   resourceUrl: string,
   options: RequestInitExtended = {},
 ): Promise<{ parameters: IriTemplateMapping[] }> {
-  return fetchJsonLd(
+  const response = await fetchJsonLd(
     resourceUrl,
     // oxlint-disable-next-line prefer-object-spread
     Object.assign({ itemsPerPage: 0 }, options),
-  ).then((d: ResponseDocument | EmptyResponseDocument) => {
-    let hasPrefix = true;
-    if ((d as ResponseDocument).body) {
-      hasPrefix = "hydra:search" in (d as ResponseDocument).body;
-    }
-    return {
-      parameters: (hasPrefix
-        ? (d as any)?.body?.["hydra:search"]?.["hydra:mapping"]
-        : (d as any)?.body?.search?.mapping) as unknown as IriTemplateMapping[],
-    };
-  });
+  );
+
+  let hasPrefix = true;
+  if ("body" in response) {
+    hasPrefix = "hydra:search" in response.body;
+  }
+  return {
+    parameters: (hasPrefix
+      ? (response as any)?.body?.["hydra:search"]?.["hydra:mapping"]
+      : (response as any)?.body?.search
+          ?.mapping) as unknown as IriTemplateMapping[],
+  };
 }

src/hydra/getParameters.ts

@@ -3,25 +3,23 @@ import fetchResource from "./fetchResource.js";
 import type { Resource } from "../Resource.js";
 import type { RequestInitExtended } from "./types.js";
 
-export default function getParameters(
+export default async function getParameters(
   resource: Resource,
   options: RequestInitExtended = {},
 ): Promise<Parameter[]> {
-  return fetchResource(resource.url, options).then(({ parameters = [] }) => {
-    const resourceParameters: Parameter[] = [];
-    for (const { property = null, required, variable } of parameters) {
-      if (property === null) {
-        continue;
-      }
+  const { parameters = [] } = await fetchResource(resource.url, options);
+  const resourceParameters: Parameter[] = [];
+  for (const { property = null, required, variable } of parameters) {
+    if (property === null) {
+      continue;
+    }
 
-      const { range = null } = resource.fields
-        ? resource.fields.find(({ name }) => property === name) || {}
-        : {};
+    const { range = null } =
+      resource.fields?.find(({ name }) => property === name) || {};
 
-      resourceParameters.push(new Parameter(variable, range, required, ""));
-    }
-    resource.parameters = resourceParameters;
+    resourceParameters.push(new Parameter(variable, range, required, ""));
+  }
+  resource.parameters = resourceParameters;
 
-    return resourceParameters;
-  });
+  return resourceParameters;
 }