Skip to content

[SPARK-11656][SQL] support typed aggregate in project list #9630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-11656][SQL] support typed aggregate in project list #9630

wants to merge 1 commit into from

Conversation

@cloud-fan
Copy link
Contributor

@cloud-fan cloud-fan commented Nov 11, 2015

insert aEncoder like we do in agg

@cloud-fan
Copy link
Contributor Author

cloud-fan commented Nov 11, 2015

cc @marmbrus

@SparkQA
Copy link

SparkQA commented Nov 11, 2015

Test build #45637 has finished for PR 9630 at commit 56422c0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Nov 11, 2015
@cloud-fan @marmbrus
[SPARK-11656][SQL] support typed aggregate in project list
f9aeb96 
insert `aEncoder` like we do in `agg`

Author: Wenchen Fan <[email protected]>

Closes #9630 from cloud-fan/select.

(cherry picked from commit 9c57bc0)
Signed-off-by: Michael Armbrust <[email protected]>
@marmbrus
Copy link
Contributor

marmbrus commented Nov 11, 2015

Thanks, merging to master and 1.6.

@asfgit asfgit closed this in 9c57bc0 Nov 11, 2015
marmbrus
marmbrus reviewed Nov 11, 2015
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
Copy link
Contributor

@marmbrus marmbrus Nov 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should live in TypedColumn itself so we don't have to duplicate the logic.

dskrvk pushed a commit to dskrvk/spark that referenced this pull request Nov 13, 2015
@cloud-fan @dskrvk
[SPARK-11656][SQL] support typed aggregate in project list
fe7ca15 
insert `aEncoder` like we do in `agg`

Author: Wenchen Fan <[email protected]>

Closes apache#9630 from cloud-fan/select.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cloud-fan @SparkQA @marmbrus