Skip to content

[SPARK-10827] replace volatile with Atomic* in AppClient.scala. #9611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[SPARK-10827] replace volatile with Atomic* in AppClient.scala. #9611

wants to merge 3 commits into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Nov 11, 2015

This is a followup for #9317 to replace volatile fields with AtomicBoolean and AtomicReference.

zsxwing
zsxwing reviewed Nov 11, 2015
View reviewed changes
core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala Outdated
Copy link
Member

@zsxwing zsxwing Nov 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registrationRetryTimer.get != null

@zsxwing
Copy link
Member

zsxwing commented Nov 11, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Nov 11, 2015

Test build #2034 has finished for PR 9611 at commit b083309.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 11, 2015

Test build #2036 has finished for PR 9611 at commit b083309.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 11, 2015

Test build #2037 has finished for PR 9611 at commit b083309.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 11, 2015

Test build #2042 has started for PR 9611 at commit b083309.

@SparkQA
Copy link

SparkQA commented Nov 11, 2015

Test build #2044 has finished for PR 9611 at commit b083309.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Nov 11, 2015
@rxin
[SPARK-10827] replace volatile with Atomic* in AppClient.scala.
fdb7774 
This is a followup for #9317 to replace volatile fields with AtomicBoolean and AtomicReference.

Author: Reynold Xin <[email protected]>

Closes #9611 from rxin/SPARK-10827.

(cherry picked from commit e1bcf6a)
Signed-off-by: Reynold Xin <[email protected]>
@rxin
Copy link
Contributor Author

rxin commented Nov 11, 2015

I've merged this.

@asfgit asfgit closed this in e1bcf6a Nov 11, 2015
dskrvk pushed a commit to dskrvk/spark that referenced this pull request Nov 13, 2015
@rxin @dskrvk
[SPARK-10827] replace volatile with Atomic* in AppClient.scala.
138e78d 
This is a followup for apache#9317 to replace volatile fields with AtomicBoolean and AtomicReference.

Author: Reynold Xin <[email protected]>

Closes apache#9611 from rxin/SPARK-10827.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rxin @zsxwing @SparkQA