[SPARK-11639][STREAMING][FLAKY-TEST] Implement BlockingWriteAheadLog for testing the BatchedWriteAheadLog #9605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #45556 has finished for PR 9605 at commit
|
|
Test build #45551 has finished for PR 9605 at commit
|
Contributor
There was a problem hiding this comment.
grammar:it takes time for 3 to get written
|
Test build #45560 has finished for PR 9605 at commit
|
Contributor
|
Also update PR title. :) |
brkyvz
changed the title
Contributor
There was a problem hiding this comment.
Why do you need this function? Can you use the private method tester to directly access walWriteQueue?
|
Test build #45580 has finished for PR 9605 at commit
|
|
Test build #2035 has finished for PR 9605 at commit
|
Contributor
|
I am merging this to master and 1.6. Thanks @brkyvz for getting this done fast |
Contributor
Author
|
@tdas I guess it didn't merge :( |
asfgit
pushed a commit
that referenced
this pull request
Nov 11, 2015
…for testing the BatchedWriteAheadLog Several elements could be drained if the main thread is not fast enough. zsxwing warned me about a similar problem, but missed it here :( Submitting the fix using a waiter. cc tdas Author: Burak Yavuz <[email protected]> Closes #9605 from brkyvz/fix-flaky-test. (cherry picked from commit 27029bc) Signed-off-by: Tathagata Das <[email protected]>
dskrvk
pushed a commit
to dskrvk/spark
that referenced
this pull request
Nov 13, 2015
…for testing the BatchedWriteAheadLog Several elements could be drained if the main thread is not fast enough. zsxwing warned me about a similar problem, but missed it here :( Submitting the fix using a waiter. cc tdas Author: Burak Yavuz <[email protected]> Closes apache#9605 from brkyvz/fix-flaky-test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several elements could be drained if the main thread is not fast enough. @zsxwing warned me about a similar problem, but missed it here :( Submitting the fix using a waiter.
cc @tdas