SPARK-11402: Use ChildRunnerProvider to create ExecutorRunner and DriverRunner #9354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verRunner Abstracted ExecutorRunner and DriverRunner. The current implementations were renamed to ExecutorRunnerImpl and DriverRunnerImpl respectively. Added a way to provide a custom implemnetation of the runners by defining their factories.
|
Test build #44599 has finished for PR 9354 at commit
|
Member
|
Maybe we might have to correct the title just like the others, |
Contributor
|
So I feel like I'm missing the motivation for this change, it seems like @srowen also had some concerns with what the goals were for this in the JIRA. |
Member
|
Yes, this PR should be closed. Per discussion in the JIRA, this just is too much SPI to open up for not obvious gain. There may be much more modest refactorings that could be done here though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstracted ExecutorRunner and DriverRunner. The current implementations were renamed to ExecutorRunnerImpl and DriverRunnerImpl respectively.
Added a way to provide a custom implemnetation of the runners by defining their factories.