[SPARK-9876] [SQL] Bumps parquet-mr to 1.8.1 #9225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liancheng
force-pushed
the
spark-9876.parquet-mr-1.8.1
branch
from
d00ff45 to
020daf1
Compare
|
Test build #44153 has finished for PR 9225 at commit
|
|
Test build #44151 timed out for PR 9225 at commit |
|
Test build #44428 has finished for PR 9225 at commit
|
Contributor
|
@liancheng Do we have a workaround for PARQUET-251? If yes, we could skip 1.8.1, since it's not in a good state, wait for 1.8.2 instead. |
Contributor
Author
|
@davies The current master and branch-1.5 have already worked around this issue by disabling Parquet filter push-down for binary and string columns. So in either way, we face performance regression in one way or another. |
Contributor
Author
|
Closing this since we decided not to bump parquet-mr to 1.8.1 for 1.6. |
ianlcsd
added a commit
to ianlcsd/spark
that referenced
this pull request
Nov 19, 2015
- manual porting apache#9225 - helpful tests: org.apache.spark.sql.execution.datasources.parquet.BinaryTest and org.apache.spark.sql.execution.datasources.parquet.ParquetFilterSuite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps parquet-mr to 1.8.1 to fix PARQUET-251.
One unexpected issue is that parquet-mr 1.8.1 doesn't allow instantiating empty Parquet schema (PARQUET-278). This affects queries like
SELECT COUNT(1) FROM t, since we have to leave at least one column in Parquet requested schema. This PR works around this issue by selecting the "narrowest" column when no columns is requested. This issue has already been fixed in parquet-mr 1.8.2-SNAPSHOT (PARQUET-363).UPDATE We worked around the above issue by constructing a non-empty
MessageTypeand then remove all its fields. See this commit.