Skip to content

Conversation

@liancheng
Copy link
Contributor

@SparkQA
Copy link

SparkQA commented Apr 3, 2015

Test build #29669 has started for PR 5348 at commit 9840aff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the backquotes because the rendered text looks funny.

@liancheng
Copy link
Contributor Author

Added Python snippet for metadata refreshing after adding refreshTable for PySpark in #5349.

@SparkQA
Copy link

SparkQA commented Apr 3, 2015

Test build #29670 has started for PR 5348 at commit a56483a.

@SparkQA
Copy link

SparkQA commented Apr 3, 2015

Test build #29669 has finished for PR 5348 at commit 9840aff.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29669/
Test PASSed.

@yhuai
Copy link
Contributor

yhuai commented Apr 3, 2015

I just found we have an example having the old code (https://spark.apache.org/docs/1.3.0/sql-programming-guide.html#programmatically-specifying-the-schema). We still have the following

// Import Spark SQL data types and Row.
import org.apache.spark.sql._

Can you update it to use import org.apache.spark.sql.types._ for data types?

@SparkQA
Copy link

SparkQA commented Apr 3, 2015

Test build #29670 has finished for PR 5348 at commit a56483a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29670/
Test PASSed.

@liancheng
Copy link
Contributor Author

@yhuai This typo has been fixed in master and branch-1.3.

@SparkQA
Copy link

SparkQA commented Apr 3, 2015

Test build #29674 has started for PR 5348 at commit 22d7b14.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it is under Hive metastore Parquet table conversion. However, users may need to call refresh table in other cases, right? For example, when they manually copy data to the dir of a data source table.

@SparkQA
Copy link

SparkQA commented Apr 3, 2015

Test build #29674 has finished for PR 5348 at commit 22d7b14.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29674/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Apr 27, 2015

Test build #31029 has started for PR 5348 at commit 22d7b14.

@andrewor14
Copy link
Contributor

@liancheng @yhuai what happened here? Do we still want to merge this?

@liancheng
Copy link
Contributor Author

@yhuai I guess it's OK to merge this?

@yhuai
Copy link
Contributor

yhuai commented Jun 21, 2015

@liancheng Yeah, it's fine to merge it. btw, you have added refreshTable in Python, right? We can update the description. Also, can you build the doc to double check the generated doc looks fine?

@liancheng liancheng force-pushed the sql-doc-parquet-conversion branch from 22d7b14 to 42ae0d0 Compare June 23, 2015 20:34
@liancheng
Copy link
Contributor Author

@yhuai Finished updating Python refreshTable snippet and double checking rendered docs. Will merge this pending Jenkins.

@AmplabJenkins
Copy link

Merged build triggered.

@yhuai
Copy link
Contributor

yhuai commented Jun 23, 2015

Sure. Thanks!

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented Jun 23, 2015

Test build #35586 has started for PR 5348 at commit 42ae0d0.

@andrewor14
Copy link
Contributor

(you could just merge this since Jenkins doesn't actually test the docs)

@SparkQA
Copy link

SparkQA commented Jun 23, 2015

Test build #35586 has finished for PR 5348 at commit 42ae0d0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@liancheng
Copy link
Contributor Author

@andrewor14 Yeah... Thanks :) Merging to master.

@asfgit asfgit closed this in d96d7b5 Jun 23, 2015
@liancheng liancheng deleted the sql-doc-parquet-conversion branch June 23, 2015 21:25
rohitagarwal003 added a commit to rohitagarwal003/spark that referenced this pull request Nov 7, 2015
This snippet seems to be mistakenly introduced at two places in apache#5348.
asfgit pushed a commit that referenced this pull request Nov 8, 2015
This snippet seems to be mistakenly introduced at two places in #5348.

Author: Rohit Agarwal <[email protected]>

Closes #9540 from mindprince/patch-1.

(cherry picked from commit 5c4e6d7)
Signed-off-by: Sean Owen <[email protected]>
asfgit pushed a commit that referenced this pull request Nov 8, 2015
This snippet seems to be mistakenly introduced at two places in #5348.

Author: Rohit Agarwal <[email protected]>

Closes #9540 from mindprince/patch-1.

(cherry picked from commit 5c4e6d7)
Signed-off-by: Sean Owen <[email protected]>
asfgit pushed a commit that referenced this pull request Nov 8, 2015
This snippet seems to be mistakenly introduced at two places in #5348.

Author: Rohit Agarwal <[email protected]>

Closes #9540 from mindprince/patch-1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants