Skip to content

[SPARK-49898][CORE] Fix documentation and default for event log task metrics accumulator logging flag from SPARK-42204 #48372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-49898][CORE] Fix documentation and default for event log task metrics accumulator logging flag from SPARK-42204 #48372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions core/src/main/scala/org/apache/spark/internal/config/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,15 +273,15 @@ package object config {

private[spark] val EVENT_LOG_INCLUDE_TASK_METRICS_ACCUMULATORS =
ConfigBuilder("spark.eventLog.includeTaskMetricsAccumulators")
.doc("Whether to include TaskMetrics' underlying accumulator values in the event log (as " +
"part of the Task/Stage/Job metrics' 'Accumulables' fields. This configuration defaults " +
"to false because the TaskMetrics values are already logged in the 'Task Metrics' " +
"fields (so the accumulator updates are redundant). This flag exists only as a " +
"backwards-compatibility escape hatch for applications that might rely on the old " +
"behavior. See SPARK-42204 for details.")
.doc("Whether to include TaskMetrics' underlying accumulator values in the event log " +
"(as part of the Task/Stage/Job metrics' 'Accumulables' fields. The TaskMetrics " +
"values are already logged in the 'Task Metrics' fields (so the accumulator updates " +
"are redundant). This flag defaults to true for behavioral backwards compatibility " +
"for applications that might rely on the redundant logging. " +
"See SPARK-42204 for details.")
.version("4.0.0")
.booleanConf
.createWithDefault(false)
.createWithDefault(true)

private[spark] val EVENT_LOG_OVERWRITE =
ConfigBuilder("spark.eventLog.overwrite")
Expand Down