Skip to content

[SPARK-49719][SQL] Make UUID and SHUFFLE accept integer seed #48166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-49719][SQL] Make UUID and SHUFFLE accept integer seed #48166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ trait ExpressionWithRandomSeed extends Expression {

private[catalyst] object ExpressionWithRandomSeed {
def expressionToSeed(e: Expression, source: String): Option[Long] = e match {
Copy link
Contributor Author

@zhengruifeng zhengruifeng Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this helper function is only used in uuid and shuffle for now

case IntegerLiteral(seed) => Some(seed)
case LongLiteral(seed) => Some(seed)
case Literal(null, _) => None
case _ => throw QueryCompilationErrors.invalidRandomSeedParameter(source, e)
Expand Down
8 changes: 8 additions & 0 deletions ...src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2293,6 +2293,14 @@ class CollectionExpressionsSuite
evaluateWithMutableProjection(Shuffle(ai0, seed2)))
assert(evaluateWithUnsafeProjection(Shuffle(ai0, seed1)) !==
evaluateWithUnsafeProjection(Shuffle(ai0, seed2)))

val seed3 = Literal.create(r.nextInt())
assert(evaluateWithoutCodegen(new Shuffle(ai0, seed3)) ===
evaluateWithoutCodegen(new Shuffle(ai0, seed3)))
assert(evaluateWithMutableProjection(new Shuffle(ai0, seed3)) ===
evaluateWithMutableProjection(new Shuffle(ai0, seed3)))
assert(evaluateWithUnsafeProjection(new Shuffle(ai0, seed3)) ===
evaluateWithUnsafeProjection(new Shuffle(ai0, seed3)))
}

test("Array Except") {
Expand Down
7 changes: 7 additions & 0 deletions ...alyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MiscExpressionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ class MiscExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
evaluateWithMutableProjection(Uuid(seed2)))
assert(evaluateWithUnsafeProjection(Uuid(seed1)) !==
evaluateWithUnsafeProjection(Uuid(seed2)))

val seed3 = Literal.create(r.nextInt())
assert(evaluateWithoutCodegen(new Uuid(seed3)) === evaluateWithoutCodegen(new Uuid(seed3)))
assert(evaluateWithMutableProjection(new Uuid(seed3)) ===
evaluateWithMutableProjection(new Uuid(seed3)))
assert(evaluateWithUnsafeProjection(new Uuid(seed3)) ===
evaluateWithUnsafeProjection(new Uuid(seed3)))
}

test("PrintToStderr") {
Expand Down