[SPARK-49718][PS] Switch Scatter plot to sampled data
#48164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Sep 19, 2024
Member
|
Merged to master. Thank you all. |
Member
|
Late LGTM, thank you! |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request?
Switch `Scatter` plot to sampled data
### Why are the changes needed?
when the data distribution has relationship with the order, the first n rows will not be representative of the whole dataset
for example:
```
import pandas as pd
import numpy as np
import pyspark.pandas as ps
# ps.set_option("plotting.max_rows", 10000)
np.random.seed(123)
pdf = pd.DataFrame(np.random.randn(10000, 4), columns=list('ABCD')).sort_values("A")
psdf = ps.DataFrame(pdf)
psdf.plot.scatter(x='B', y='A')
```
all 10k datapoints:
before (first 1k datapoints):
after (sampled 1k datapoints):
### Does this PR introduce _any_ user-facing change?
yes
### How was this patch tested?
ci and manually test
### Was this patch authored or co-authored using generative AI tooling?
no
Closes apache#48164 from zhengruifeng/ps_scatter_sampling.
Authored-by: Ruifeng Zheng <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request?
Switch `Scatter` plot to sampled data
### Why are the changes needed?
when the data distribution has relationship with the order, the first n rows will not be representative of the whole dataset
for example:
```
import pandas as pd
import numpy as np
import pyspark.pandas as ps
# ps.set_option("plotting.max_rows", 10000)
np.random.seed(123)
pdf = pd.DataFrame(np.random.randn(10000, 4), columns=list('ABCD')).sort_values("A")
psdf = ps.DataFrame(pdf)
psdf.plot.scatter(x='B', y='A')
```
all 10k datapoints:
before (first 1k datapoints):
after (sampled 1k datapoints):
### Does this PR introduce _any_ user-facing change?
yes
### How was this patch tested?
ci and manually test
### Was this patch authored or co-authored using generative AI tooling?
no
Closes apache#48164 from zhengruifeng/ps_scatter_sampling.
Authored-by: Ruifeng Zheng <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Switch
Scatterplot to sampled dataWhy are the changes needed?
when the data distribution has relationship with the order, the first n rows will not be representative of the whole dataset
for example:
all 10k datapoints:
before (first 1k datapoints):
after (sampled 1k datapoints):
Does this PR introduce any user-facing change?
yes
How was this patch tested?
ci and manually test
Was this patch authored or co-authored using generative AI tooling?
no