From 69bb5d8dc9268e68b844c92a524eee990b5a0ff8 Mon Sep 17 00:00:00 2001 From: yangjie01 Date: Mon, 25 Dec 2023 18:07:11 +0800 Subject: [PATCH 1/2] init --- .../parquet/ParquetTypeWideningSuite.scala | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetTypeWideningSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetTypeWideningSuite.scala index 72580f7078e2..4b8fc1946e14 100644 --- a/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetTypeWideningSuite.scala +++ b/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetTypeWideningSuite.scala @@ -166,11 +166,17 @@ class ParquetTypeWideningSuite (Seq("1", "2", Int.MinValue.toString), LongType, IntegerType), (Seq("1.23", "10.34"), DoubleType, FloatType), (Seq("1.23", "10.34"), FloatType, LongType), - (Seq("1.23", "10.34"), LongType, DateType), - (Seq("1.23", "10.34"), IntegerType, TimestampType), - (Seq("1.23", "10.34"), IntegerType, TimestampNTZType), (Seq("2020-01-01", "2020-01-02", "1312-02-27"), DateType, TimestampType) - ) + ) ++ { + if (SQLConf.get.ansiEnabled) Nil + else { + Seq( + (Seq("1.23", "10.34"), LongType, DateType), + (Seq("1.23", "10.34"), IntegerType, TimestampType), + (Seq("1.23", "10.34"), IntegerType, TimestampNTZType) + ) + } + } } test(s"unsupported parquet conversion $fromType -> $toType") { checkAllParquetReaders(values, fromType, toType, expectError = true) From d95098c75bce2881913cb0efb8ab518efd9db372 Mon Sep 17 00:00:00 2001 From: yangjie01 Date: Mon, 25 Dec 2023 20:06:29 +0800 Subject: [PATCH 2/2] use valid int --- .../parquet/ParquetTypeWideningSuite.scala | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetTypeWideningSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetTypeWideningSuite.scala index 4b8fc1946e14..0a8618944241 100644 --- a/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetTypeWideningSuite.scala +++ b/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetTypeWideningSuite.scala @@ -166,17 +166,11 @@ class ParquetTypeWideningSuite (Seq("1", "2", Int.MinValue.toString), LongType, IntegerType), (Seq("1.23", "10.34"), DoubleType, FloatType), (Seq("1.23", "10.34"), FloatType, LongType), + (Seq("1", "10"), LongType, DateType), + (Seq("1", "10"), IntegerType, TimestampType), + (Seq("1", "10"), IntegerType, TimestampNTZType), (Seq("2020-01-01", "2020-01-02", "1312-02-27"), DateType, TimestampType) - ) ++ { - if (SQLConf.get.ansiEnabled) Nil - else { - Seq( - (Seq("1.23", "10.34"), LongType, DateType), - (Seq("1.23", "10.34"), IntegerType, TimestampType), - (Seq("1.23", "10.34"), IntegerType, TimestampNTZType) - ) - } - } + ) } test(s"unsupported parquet conversion $fromType -> $toType") { checkAllParquetReaders(values, fromType, toType, expectError = true)