[SPARK-46227][SQL] Move withSQLConf from SQLHelper to SQLConfHelper
#44142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @dongjoon-hyun @cloud-fan thank you |
dongjoon-hyun
changed the title
withSQLConf from SQLHelper trait to SQLConfHelper traitwithSQLConf from SQLHelper to SQLConfHelper
dongjoon-hyun
approved these changes
Dec 4, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM.
Thank you so much, @ulysses-you .
beliefer
reviewed
Dec 4, 2023
| * Sets all SQL configurations specified in `pairs`, calls `f`, and then restores all SQL | ||
| * configurations. | ||
| */ | ||
| protected def withSQLConf[T](pairs: (String, String)*)(f: => T): T = { |
Contributor
There was a problem hiding this comment.
Why change it to type parameter?
Contributor
There was a problem hiding this comment.
Then it can return things, looks reasonable
Member
There was a problem hiding this comment.
Ya, the PR description descirbed the goal, @beliefer
To make it easy to use such case: val x = withSQLConf {}, this pr also changes its return type.
cloud-fan
approved these changes
Dec 4, 2023
Member
|
Merged to master for Apache Spark 4. |
Member
|
Thank you, @ulysses-you , @beliefer , @cloud-fan . |
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Dec 5, 2023
…per`
### What changes were proposed in this pull request?
This pr moves method `withSQLConf` from `SQLHelper` in catalyst test module to `SQLConfHelper` trait in catalyst module. To make it easy to use such case: `val x = withSQLConf {}`, this pr also changes its return type.
### Why are the changes needed?
A part of apache#44013
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
Pass CI
### Was this patch authored or co-authored using generative AI tooling?
no
Closes apache#44142 from ulysses-you/withSQLConf.
Authored-by: ulysses-you <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
…per`
### What changes were proposed in this pull request?
This pr moves method `withSQLConf` from `SQLHelper` in catalyst test module to `SQLConfHelper` trait in catalyst module. To make it easy to use such case: `val x = withSQLConf {}`, this pr also changes its return type.
### Why are the changes needed?
A part of apache#44013
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
Pass CI
### Was this patch authored or co-authored using generative AI tooling?
no
Closes apache#44142 from ulysses-you/withSQLConf.
Authored-by: ulysses-you <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr moves method
withSQLConffromSQLHelperin catalyst test module toSQLConfHelpertrait in catalyst module. To make it easy to use such case:val x = withSQLConf {}, this pr also changes its return type.Why are the changes needed?
A part of #44013
Does this PR introduce any user-facing change?
no
How was this patch tested?
Pass CI
Was this patch authored or co-authored using generative AI tooling?
no