[SPARK-45342][BUILD] Remove the scala doc compilation option specific to Scala 2.12 #43129
Conversation
project/SparkBuild.scala
Outdated
| ) ++ { | ||
| // Do not attempt to scaladoc javadoc comments under 2.12 since it can't handle inner classes | ||
| if (scalaBinaryVersion.value == "2.12") Seq("-no-java-comments") else Seq.empty | ||
| if (scalaBinaryVersion.value == "2.13") Seq("-no-java-comments") else Seq.empty |
There was a problem hiding this comment.
@srowen @easel I've found a leftover Scala 2.12 version check here, but when using the check method provided in #20042: sbt tags/publishLocal, I couldn't distinguish the scala doc built with or without -no-java-comments. I hope to get your help, how should we determine whether to keep the option -no-java-comments for Scala 2.13? Thanks ~
There was a problem hiding this comment.
I think you should just remove this part, right? does not apply in Scala 2.13
There was a problem hiding this comment.
Thanks for your help @srowen , but I found that there are errors when executing build/sbt doc -Phadoop-3 -Phadoop-cloud -Pmesos -Pyarn -Pkinesis-asl -Phive-thriftserver -Pspark-ganglia-lgpl -Pkubernetes -Phive -Pvolcano. Let me fix them first.
LuciferYang
changed the title
|
we can use #43158, close this one |
2 participants
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?