Skip to content

Conversation

@liancheng
Copy link
Contributor

This PR tries to fix the Hive tests failure encountered in PR #3157 by cleaning lib_managed before building assembly jar against Hive 0.13.1 in dev/run-tests. Otherwise two sets of datanucleus jars would be left in lib_managed and may mess up class paths while executing Hive test suites. Please refer to this thread for details. A clean build would be even safer, but we only clean lib_managed here to save build time.

This PR also takes the chance to clean up some minor typos and formatting issues in the comments.

Review on Reviewable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this line to clearly indicate the following build is against Hive 0.13.1.

@SparkQA
Copy link

SparkQA commented Dec 21, 2014

Test build #24683 has started for PR 3756 at commit c9f2f3e.

  • This patch merges cleanly.

@liancheng liancheng changed the title [SPARK-][Build] Cleans lib_managed before compiling with Hive 0.13.1 [SPARK-4914][Build] Cleans lib_managed before compiling with Hive 0.13.1 Dec 21, 2014
@SparkQA
Copy link

SparkQA commented Dec 21, 2014

Test build #24683 has finished for PR 3756 at commit c9f2f3e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24683/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Dec 21, 2014

Test build #24686 has started for PR 3756 at commit e2bd21d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 21, 2014

Test build #24686 has finished for PR 3756 at commit e2bd21d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24686/
Test PASSed.

@liancheng
Copy link
Contributor Author

@pwendell @JoshRosen Would you please take a look at this? This issue is causing random PR build failures. Thanks!

@JoshRosen
Copy link
Contributor

LGTM, so I'll merge this into master (1.3.0) and branch-1.2 (1.2.1). Thanks for the fix!

asfgit pushed a commit that referenced this pull request Dec 23, 2014
This PR tries to fix the Hive tests failure encountered in PR #3157 by cleaning `lib_managed` before building assembly jar against Hive 0.13.1 in `dev/run-tests`. Otherwise two sets of datanucleus jars would be left in `lib_managed` and may mess up class paths while executing Hive test suites. Please refer to [this thread] [1] for details. A clean build would be even safer, but we only clean `lib_managed` here to save build time.

This PR also takes the chance to clean up some minor typos and formatting issues in the comments.

[1]: #3157 (comment)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/3756)
<!-- Reviewable:end -->

Author: Cheng Lian <[email protected]>

Closes #3756 from liancheng/clean-lib-managed and squashes the following commits:

e2bd21d [Cheng Lian] Adds lib_managed to clean set
c9f2f3e [Cheng Lian] Cleans lib_managed before compiling with Hive 0.13.1

(cherry picked from commit 395b771)
Signed-off-by: Josh Rosen <[email protected]>
@asfgit asfgit closed this in 395b771 Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants