-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-4914][Build] Cleans lib_managed before compiling with Hive 0.13.1 #3756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this line to clearly indicate the following build is against Hive 0.13.1.
|
Test build #24683 has started for PR 3756 at commit
|
|
Test build #24683 has finished for PR 3756 at commit
|
|
Test PASSed. |
|
Test build #24686 has started for PR 3756 at commit
|
|
Test build #24686 has finished for PR 3756 at commit
|
|
Test PASSed. |
|
@pwendell @JoshRosen Would you please take a look at this? This issue is causing random PR build failures. Thanks! |
|
LGTM, so I'll merge this into |
This PR tries to fix the Hive tests failure encountered in PR #3157 by cleaning `lib_managed` before building assembly jar against Hive 0.13.1 in `dev/run-tests`. Otherwise two sets of datanucleus jars would be left in `lib_managed` and may mess up class paths while executing Hive test suites. Please refer to [this thread] [1] for details. A clean build would be even safer, but we only clean `lib_managed` here to save build time. This PR also takes the chance to clean up some minor typos and formatting issues in the comments. [1]: #3157 (comment) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/3756) <!-- Reviewable:end --> Author: Cheng Lian <[email protected]> Closes #3756 from liancheng/clean-lib-managed and squashes the following commits: e2bd21d [Cheng Lian] Adds lib_managed to clean set c9f2f3e [Cheng Lian] Cleans lib_managed before compiling with Hive 0.13.1 (cherry picked from commit 395b771) Signed-off-by: Josh Rosen <[email protected]>
This PR tries to fix the Hive tests failure encountered in PR #3157 by cleaning
lib_managedbefore building assembly jar against Hive 0.13.1 indev/run-tests. Otherwise two sets of datanucleus jars would be left inlib_managedand may mess up class paths while executing Hive test suites. Please refer to this thread for details. A clean build would be even safer, but we only cleanlib_managedhere to save build time.This PR also takes the chance to clean up some minor typos and formatting issues in the comments.