[SPARK-39663][SQL][TESTS] Add UT for MysqlDialect listIndexes method #37060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@huaxingao |
|
Can one of the admins verify this patch? |
huaxingao
reviewed
Jul 4, 2022
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala
Outdated
Show resolved
Hide resolved
srowen
reviewed
Jul 5, 2022
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala
Outdated
Show resolved
Hide resolved
LuciferYang
reviewed
Jul 5, 2022
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala
Outdated
Show resolved
Hide resolved
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala
Outdated
Show resolved
Hide resolved
srowen
reviewed
Jul 5, 2022
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala
Outdated
Show resolved
Hide resolved
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala
Outdated
Show resolved
Hide resolved
huaxingao
approved these changes
Jul 6, 2022
srowen
approved these changes
Jul 6, 2022
Member
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add complemented UT for MysqlDialect's lustIndexes method.
Why are the changes needed?
Add UT for existed function & improve test coverage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.