From 3d84e16dad8f43e16c48c00e6f14a82b50572823 Mon Sep 17 00:00:00 2001 From: weixiuli Date: Thu, 25 Nov 2021 19:40:45 +0800 Subject: [PATCH] [SPARK-37462][CORE] Avoid unnecessary calculating the number of outstanding fetch requests and RPCS --- .../apache/spark/network/server/TransportChannelHandler.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/network-common/src/main/java/org/apache/spark/network/server/TransportChannelHandler.java b/common/network-common/src/main/java/org/apache/spark/network/server/TransportChannelHandler.java index 2d439473bc22..275e64ee50f2 100644 --- a/common/network-common/src/main/java/org/apache/spark/network/server/TransportChannelHandler.java +++ b/common/network-common/src/main/java/org/apache/spark/network/server/TransportChannelHandler.java @@ -158,10 +158,10 @@ public void userEventTriggered(ChannelHandlerContext ctx, Object evt) throws Exc // To avoid a race between TransportClientFactory.createClient() and this code which could // result in an inactive client being returned, this needs to run in a synchronized block. synchronized (this) { - boolean hasInFlightRequests = responseHandler.numOutstandingRequests() > 0; boolean isActuallyOverdue = System.nanoTime() - responseHandler.getTimeOfLastRequestNs() > requestTimeoutNs; if (e.state() == IdleState.ALL_IDLE && isActuallyOverdue) { + boolean hasInFlightRequests = responseHandler.numOutstandingRequests() > 0; if (hasInFlightRequests) { String address = getRemoteAddress(ctx.channel()); logger.error("Connection to {} has been quiet for {} ms while there are outstanding " +