Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Nov 12, 2014

Because of the type erase, the unit tests will pass. However, the wrong variable types will confuse people.

@SparkQA
Copy link

SparkQA commented Nov 12, 2014

Test build #23267 has started for PR 3227 at commit b0c3ac9.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 12, 2014

Test build #23267 has finished for PR 3227 at commit b0c3ac9.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23267/
Test FAILed.

@srowen
Copy link
Member

srowen commented Nov 12, 2014

This change exactly is also in #3157 , which has other fixes. Definitely want to get this in among other warning touch-ups.

@zsxwing zsxwing closed this Nov 13, 2014
@zsxwing zsxwing deleted the SPARK-4364 branch November 13, 2014 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants