Skip to content

Conversation

@huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

Override the default SQL strings for

  • ALTER TABLE ADD COLUMN
  • ALTER TABLE RENAME COLUMN
  • ALTER TABLE DROP COLUMN
  • ALTER TABLE UPDATE COLUMN TYPE
  • ALTER TABLE UPDATE COLUMN NULLABILITY

in the following JDBC dialects according to official documentation:

  • DB2
  • Derby
  • MS SQL Server
  • MYSQL
  • Oracle
  • Postgres
  • Teradata

Why are the changes needed?

To have correct implementation of alter table for all supported JDBC dialects.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Manually check the SQL strings are built correctly

@SparkQA
Copy link

SparkQA commented Aug 30, 2020

Test build #128031 has finished for PR 29581 at commit 3ae04d4.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@huaxingao
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Aug 30, 2020

Test build #128049 has finished for PR 29581 at commit 3ae04d4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@huaxingao
Copy link
Contributor Author

cc @MaxGekk @cloud-fan @viirya

@cloud-fan
Copy link
Contributor

Can we have docker tests for these databases with JDBC v2?

@huaxingao
Copy link
Contributor Author

Can we have docker tests for these databases with JDBC v2?
Sorry, busy days. Didn't have a chance to work on this yet, but I will.

@MaxGekk
Copy link
Member

MaxGekk commented Sep 30, 2020

I propose to open separate PR per every supported dialect with docker integration tests. Here is the PR for the Oracle dialect: #29912

@huaxingao huaxingao closed this Dec 1, 2020
@huaxingao huaxingao deleted the jdbc_dialect_altertable branch December 1, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants