Skip to content

[SPARK-32678][SQL] Rename EmptyHashedRelationWithAllNullKeys and simplify NAAJ generated code #29503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-32678][SQL] Rename EmptyHashedRelationWithAllNullKeys and simplify NAAJ generated code #29503

wants to merge 1 commit into from

Conversation

@leanken-zz
Copy link
Contributor

@leanken-zz leanken-zz commented Aug 21, 2020

What changes were proposed in this pull request?

Some Code refine.

  1. rename EmptyHashedRelationWithAllNullKeys to HashedRelationWithAllNullKeys.
  2. simplify generated code for BHJ NAAJ.

Why are the changes needed?

Refine code and naming to avoid confusing understanding.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing test.

@leanken-zz
Code refine.
809e472 
1. rename EmptyHashedRelationWithAllNullKeys to HashedRelationWithAllNullKeys.
2. simplify generated code for BHJ NAAJ.

Change-Id: If91057b60898c0233f93cd9363dde718e3e1e49e
@leanken-zz
Copy link
Contributor Author

leanken-zz commented Aug 21, 2020

@viirya Could you please have a look at this minor change.

@viirya
Copy link
Member

viirya commented Aug 22, 2020

ok to test

viirya
viirya approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

@leanken-zz
Copy link
Contributor Author

leanken-zz commented Aug 22, 2020

Looks okay to me.

thanks

@SparkQA
Copy link

SparkQA commented Aug 22, 2020

Test build #127768 has finished for PR 29503 at commit 809e472.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@leanken-zz
Copy link
Contributor Author

leanken-zz commented Aug 23, 2020

@viirya Test passed, is it ok to merge?

@viirya viirya closed this in f258718 Aug 23, 2020
@viirya
Copy link
Member

viirya commented Aug 23, 2020

Thanks! Merging to master.

@c21 c21 mentioned this pull request Aug 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viirya viirya viirya approved these changes

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leanken-zz @viirya @SparkQA