Skip to content

[SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite #28536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-31716][SQL] Use fallback versions in HiveExternalCatalogVersionsSuite #28536

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d44e9e
[WIP][SPARK-XXX][SQL] Use a fallback version in HiveExternalCatalogVe…
dongjoon-hyun May 15, 2020
5505ab1
Add 2.3.4, too
dongjoon-hyun May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ object PROCESS_TABLES extends QueryTest with SQLTestUtils {
.filter(_ < org.apache.spark.SPARK_VERSION)
} catch {
// do not throw exception during object initialization.
case NonFatal(_) => Nil
case NonFatal(_) => Seq("2.3.4", "2.4.5") // A temporary fallback to use a specific version
Copy link
Member

@HyukjinKwon HyukjinKwon May 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongjoon-hyun, is it a temporary fix? If we want to keep this, looks like we don't need to try to have this list above.

Copy link
Member

@HyukjinKwon HyukjinKwon May 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay. Just read about SPARK-31717.

}
}

Expand Down