[MINOR][SQL][TESTS] Disable UI in SQL benchmarks by default #28432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #122179 has finished for PR 28432 at commit
|
maropu
reviewed
May 1, 2020
| package org.apache.spark.sql.execution.benchmark | ||
|
|
||
| import org.apache.spark.benchmark.{Benchmark, BenchmarkBase} | ||
| import org.apache.spark.internal.config.UI._ |
Member
There was a problem hiding this comment.
nit: import org.apache.spark.internal.config.UI.UI_ENABLED
maropu
approved these changes
May 1, 2020
HyukjinKwon
approved these changes
May 2, 2020
|
Test build #122197 has finished for PR 28432 at commit
|
Member
Author
|
jenkins, retest this, please |
maropu
pushed a commit
that referenced
this pull request
May 2, 2020
### What changes were proposed in this pull request? Set `spark.ui.enabled` to `false` in `SqlBasedBenchmark.getSparkSession`. This disables UI in all SQL benchmarks by default. ### Why are the changes needed? UI overhead lowers numbers in the `Relative` column and impacts on `Stdev` in benchmark results. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Checked by running `DateTimeRebaseBenchmark`. Closes #28432 from MaxGekk/ui-off-in-benchmarks. Authored-by: Max Gekk <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]> (cherry picked from commit 13dddee) Signed-off-by: Takeshi Yamamuro <[email protected]>
Member
|
Since I checked the last commit doesn't affect test results, I've merged to mater/branch-3.0. Thanks, @MaxGekk ! |
|
Test build #122204 has finished for PR 28432 at commit
|
huaxingao
pushed a commit
to huaxingao/spark
that referenced
this pull request
May 4, 2020
### What changes were proposed in this pull request? Set `spark.ui.enabled` to `false` in `SqlBasedBenchmark.getSparkSession`. This disables UI in all SQL benchmarks by default. ### Why are the changes needed? UI overhead lowers numbers in the `Relative` column and impacts on `Stdev` in benchmark results. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Checked by running `DateTimeRebaseBenchmark`. Closes apache#28432 from MaxGekk/ui-off-in-benchmarks. Authored-by: Max Gekk <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set
spark.ui.enabledtofalseinSqlBasedBenchmark.getSparkSession. This disables UI in all SQL benchmarks by default.Why are the changes needed?
UI overhead lowers numbers in the
Relativecolumn and impacts onStdevin benchmark results.Does this PR introduce any user-facing change?
No
How was this patch tested?
Checked by running
DateTimeRebaseBenchmark.