[SPARK-31503][SQL][2.4] fix the SQL string of the TRIM functions #28299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
override the `sql` method of `StringTrim`, `StringTrimLeft` and `StringTrimRight`, to use the standard SQL syntax. The current implementation is wrong. It gives you a SQL string that returns different result. No new tests Closes apache#28281 from cloud-fan/sql. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit b209b5f) Signed-off-by: Dongjoon Hyun <[email protected]>
Contributor
Author
HyukjinKwon
approved these changes
Apr 22, 2020
|
Test build #121618 has finished for PR 28299 at commit
|
dongjoon-hyun
approved these changes
Apr 22, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to branch-2.4. Thank you, @cloud-fan and @HyukjinKwon .
cc @holdenk since she is a release manager for 2.4.6.
Member
|
Oops. I'm late. :) |
Member
|
Oh, this one seems to out of sync too. I cannot see the merged commit in GitHub branch-2.4 |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Apr 22, 2020
backport #28281 to 2.4 This backport has one difference: there is no `EXTRACT(... FROM ...)` SQL syntax in 2.4, so this PR just uses the common function call syntax. Closes #28299 from cloud-fan/pick. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #28281 to 2.4
This backport has one difference: there is no
EXTRACT(... FROM ...)SQL syntax in 2.4, so this PR just uses the common function call syntax.