[SPARK-31327][SQL][2.4] Write Spark version into Avro file metadata #28150
+116
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
HyukjinKwon
reviewed
Apr 8, 2020
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
Outdated
Show resolved
Hide resolved
Write Spark version into Avro file metadata The version info is very useful for backward compatibility. This is also done in parquet/orc. no new test Closes apache#28102 from cloud-fan/avro. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Member
|
Thank you for pinging me, @cloud-fan . |
|
Test build #120950 has finished for PR 28150 at commit
|
|
Test build #120951 has finished for PR 28150 at commit
|
Member
|
retest this please |
|
Test build #120956 has finished for PR 28150 at commit
|
dongjoon-hyun
approved these changes
Apr 8, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @cloud-fan and @HyukjinKwon .
Merged to branch-2.4.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Apr 8, 2020
Backport 6b1ca88, similar to #28142 ### What changes were proposed in this pull request? Write Spark version into Avro file metadata ### Why are the changes needed? The version info is very useful for backward compatibility. This is also done in parquet/orc. ### Does this PR introduce any user-facing change? no ### How was this patch tested? new test Closes #28150 from cloud-fan/pick. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6b1ca88, similar to #28142
What changes were proposed in this pull request?
Write Spark version into Avro file metadata
Why are the changes needed?
The version info is very useful for backward compatibility. This is also done in parquet/orc.
Does this PR introduce any user-facing change?
no
How was this patch tested?
new test