[SPARK-30756][SQL] Fix ThriftServerWithSparkContextSuite on spark-branch-3.0-test-sbt-hadoop-2.7-hive-2.3
#27513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #118106 has finished for PR 27513 at commit
|
|
Test build #118118 has finished for PR 27513 at commit
|
|
Test build #118123 has finished for PR 27513 at commit
|
|
Test build #118124 has finished for PR 27513 at commit
|
|
Test build #118129 has finished for PR 27513 at commit
|
|
Test build #118121 has finished for PR 27513 at commit
|
|
Test build #118134 has finished for PR 27513 at commit
|
Member
Author
|
retest this please |
|
Test build #118143 has finished for PR 27513 at commit
|
Member
Author
|
retest this please |
|
Test build #118157 has finished for PR 27513 at commit
|
Member
Author
|
@dongjoon-hyun, @wangyum, @shaneknapp, @srowen this is about Do you guys mind if I merge and see if this fixes |
HyukjinKwon
changed the title
ThriftServerWithSparkContextSuite on spark-branch-3.0-test-sbt-hadoop-2.7-hive-2.3
wangyum
approved these changes
Feb 11, 2020
cloud-fan
approved these changes
Feb 11, 2020
Contributor
|
shall we merge it to master as well? |
Contributor
|
tbh, i don't mind.
…On Mon, Feb 10, 2020 at 7:12 PM Hyukjin Kwon ***@***.***> wrote:
@dongjoon-hyun <https://github.com/dongjoon-hyun>, @wangyum
<https://github.com/wangyum>, @shaneknapp <https://github.com/shaneknapp>,
@srowen <https://github.com/srowen> this is about SPARK-30756. I can't
reproduce with the same profiles in PR builder and in my local. I wanted to
try this way #26710 (comment)
<#26710 (comment)>
Do you guys mind if I merge and see if this fixes
spark-branch-3.0-test-sbt-hadoop-2.7-hive-2.3
<https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-branch-3.0-test-sbt-hadoop-2.7-hive-2.3/>
?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27513?email_source=notifications&email_token=AAMIHLATVGWR7YOEF7MJG3TRCIJRFA5CNFSM4KSGXCQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELLC3RY#issuecomment-584461767>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMIHLGA43PVEEBRLEFUA6TRCIJRFANCNFSM4KSGXCQA>
.
|
Member
Author
|
Yup, I will do that. |
Member
Author
|
I will port forward to the master once the tests pass. |
|
Test build #118199 has finished for PR 27513 at commit
|
HyukjinKwon
added a commit
that referenced
this pull request
Feb 11, 2020
…ranch-3.0-test-sbt-hadoop-2.7-hive-2.3 ### What changes were proposed in this pull request? This PR tries #26710 (comment) way to fix the test. ### Why are the changes needed? To make the tests pass. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Jenkins will test first, and then `on spark-branch-3.0-test-sbt-hadoop-2.7-hive-2.3` will test it out. Closes #27513 from HyukjinKwon/test-SPARK-30756. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
Member
Author
|
Merged to master and branch-3.0. |
Member
Author
|
Okay, seems the test fixed. |
Member
|
Late LGTM. Thank you for fixing that, @HyukjinKwon ! |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…ranch-3.0-test-sbt-hadoop-2.7-hive-2.3 ### What changes were proposed in this pull request? This PR tries apache#26710 (comment) way to fix the test. ### Why are the changes needed? To make the tests pass. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Jenkins will test first, and then `on spark-branch-3.0-test-sbt-hadoop-2.7-hive-2.3` will test it out. Closes apache#27513 from HyukjinKwon/test-SPARK-30756. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit 8efe367) Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR tries #26710 (comment) way to fix the test.
Why are the changes needed?
To make the tests pass.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Jenkins will test first, and then
on spark-branch-3.0-test-sbt-hadoop-2.7-hive-2.3will test it out.