From 5de21fac6f9983ef69dbcb9f154091a1be56c588 Mon Sep 17 00:00:00 2001 From: "Jungtaek Lim (HeartSaVioR)" Date: Fri, 29 Nov 2019 16:02:21 +0900 Subject: [PATCH 1/2] [SPARK-30075][CORE] Fix the hashCode implementation of ArrayKeyIndexType correctly --- .../java/org/apache/spark/util/kvstore/ArrayKeyIndexType.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/kvstore/src/test/java/org/apache/spark/util/kvstore/ArrayKeyIndexType.java b/common/kvstore/src/test/java/org/apache/spark/util/kvstore/ArrayKeyIndexType.java index 32030fb4115c3..85ee44998f01a 100644 --- a/common/kvstore/src/test/java/org/apache/spark/util/kvstore/ArrayKeyIndexType.java +++ b/common/kvstore/src/test/java/org/apache/spark/util/kvstore/ArrayKeyIndexType.java @@ -38,7 +38,7 @@ public boolean equals(Object o) { @Override public int hashCode() { - return key.hashCode(); + return Arrays.hashCode(key); } } From 7a74f0635cdb77df908e256bed1d950c4100c2a3 Mon Sep 17 00:00:00 2001 From: "Jungtaek Lim (HeartSaVioR)" Date: Sat, 30 Nov 2019 14:25:42 +0900 Subject: [PATCH 2/2] Address review comment --- .../java/org/apache/spark/util/kvstore/ArrayKeyIndexType.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/kvstore/src/test/java/org/apache/spark/util/kvstore/ArrayKeyIndexType.java b/common/kvstore/src/test/java/org/apache/spark/util/kvstore/ArrayKeyIndexType.java index 85ee44998f01a..dd53fdf0b1b4c 100644 --- a/common/kvstore/src/test/java/org/apache/spark/util/kvstore/ArrayKeyIndexType.java +++ b/common/kvstore/src/test/java/org/apache/spark/util/kvstore/ArrayKeyIndexType.java @@ -38,7 +38,7 @@ public boolean equals(Object o) { @Override public int hashCode() { - return Arrays.hashCode(key); + return Arrays.hashCode(key) ^ Arrays.hashCode(id); } }