Skip to content

Conversation

@MaxGekk
Copy link
Member

@MaxGekk MaxGekk commented Oct 12, 2019

What changes were proposed in this pull request?

Revert this commit 18b7ad2.

Why are the changes needed?

See #16304 (comment)

Does this PR introduce any user-facing change?

Yes

How was this patch tested?

There is no test for that.

@MaxGekk
Copy link
Member Author

MaxGekk commented Oct 12, 2019

@zsxwing @srowen Please, take a look at this.

@SparkQA
Copy link

SparkQA commented Oct 12, 2019

Test build #111962 has finished for PR 26101 at commit 1a8dc4f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, OK. I get erring on the side of being conservative.

@srowen srowen closed this in f302c2e Oct 12, 2019
@zsxwing
Copy link
Member

zsxwing commented Oct 14, 2019

@MaxGekk Thanks for fixing this!

@MaxGekk MaxGekk deleted the revert-mean-seconds-per-month branch October 15, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants