Skip to content

[SPARK-3476] Remove outdated memory checks in Yarn #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-3476] Remove outdated memory checks in Yarn #2528

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e30ffac
Remove outdated memory checks
andrewor14 Sep 25, 2014
c5400cd
Simplify checks
andrewor14 Sep 25, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,9 @@ private[spark] class ClientArguments(args: Array[String], sparkConf: SparkConf)
* This is intended to be called only after the provided arguments have been parsed.
*/
private def validateArgs(): Unit = {
// TODO: memory checks are outdated (SPARK-3476)
Map[Boolean, String](
(numExecutors <= 0) -> "You must specify at least 1 executor!",
(amMemory <= amMemoryOverhead) -> s"AM memory must be > $amMemoryOverhead MB",
(executorMemory <= executorMemoryOverhead) ->
s"Executor memory must be > $executorMemoryOverhead MB"
).foreach { case (errorCondition, errorMessage) =>
if (errorCondition) {
throw new IllegalArgumentException(errorMessage + "\n" + getUsageMessage())
}
if (numExecutors <= 0) {
throw new IllegalArgumentException(
"You must specify at least 1 executor!\n" + getUsageMessage())
}
}

Expand Down