Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Jul 14, 2019

What changes were proposed in this pull request?

This PR is to port numeric.sql from PostgreSQL regression tests. https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/sql/select_implicit.sql

The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/expected/select_implicit.out

When porting the test cases, found one PostgreSQL specific features that do not exist in Spark SQL:
SPARK-28329: SELECT INTO syntax

How was this patch tested?

N/A

@SparkQA
Copy link

SparkQA commented Jul 14, 2019

Test build #107648 has finished for PR 25152 at commit a183e2d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum wangyum changed the title [WIP][SPARK-28388][SQL][TEST] Port select_implicit.sql [SPARK-28388][SQL][TEST] Port select_implicit.sql Jul 16, 2019
@SparkQA
Copy link

SparkQA commented Jul 16, 2019

Test build #107743 has finished for PR 25152 at commit c00b9d8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented Jul 18, 2019

Test build #107804 has finished for PR 25152 at commit c00b9d8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to master.
Thank you, @wangyum !

@wangyum wangyum deleted the SPARK-28388 branch July 18, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants