Skip to content

Conversation

@shahidki31
Copy link
Contributor

@shahidki31 shahidki31 commented Oct 6, 2018

What changes were proposed in this pull request?

After the PR, #22592, SQL tab supports collapsing table.
However, after refreshing the page, it doesn't store it previous state. This was due to a typo in the argument list in the collapseTablePageLoadCommand().

How was this patch tested?

bin/spark-shell

sql("create table a (id int)")
for(i <- 1 to 100) sql(s"insert into a values ($i)")

screenshot from 2018-10-06 10-19-30

Please review http://spark.apache.org/contributing.html before opening a pull request.

[Spark Job History] SQL UI Page does not support Pagination
@shahidki31
Copy link
Contributor Author

Hi @srowen , Kindly review and merge.

@shahidki31 shahidki31 changed the title [SPARK-25575][FOLLOWUP]SQL tab in the spark UI support hide tables [SPARK-25575][WEBUI][FOLLOWUP]SQL tab in the spark UI support hide tables Oct 6, 2018
@SparkQA
Copy link

SparkQA commented Oct 6, 2018

Test build #4359 has finished for PR 22650 at commit cd9ef14.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Oct 6, 2018

Merged to master

@asfgit asfgit closed this in 756a3ab Oct 6, 2018
@shahidki31
Copy link
Contributor Author

shahidki31 commented Oct 6, 2018

Thanks a lot @srowen

@shahidki31 shahidki31 deleted the SPARK-25575-followUp branch October 6, 2018 22:35
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
…ables

## What changes were proposed in this pull request?
After the PR, apache#22592, SQL tab supports collapsing table.
However, after refreshing the page, it doesn't store it previous state. This was due to a typo in the argument list in the collapseTablePageLoadCommand().

## How was this patch tested?
bin/spark-shell
```
sql("create table a (id int)")
for(i <- 1 to 100) sql(s"insert into a values ($i)")
```
![screenshot from 2018-10-06 10-19-30](https://user-images.githubusercontent.com/23054875/46567490-59bea380-c951-11e8-9484-9aa2ee84b816.png)

Please review http://spark.apache.org/contributing.html before opening a pull request.

Closes apache#22650 from shahidki31/SPARK-25575-followUp.

Authored-by: Shahid <[email protected]>
Signed-off-by: Sean Owen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants