Skip to content

[SPARK-25124][ML]VectorSizeHint setSize and getSize don't return values backport to 2.3 #22228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-25124][ML]VectorSizeHint setSize and getSize don't return values backport to 2.3 #22228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/pyspark/ml/feature.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3673,12 +3673,12 @@ def setParams(self, inputCol=None, size=None, handleInvalid="error"):
@since("2.3.0")
def getSize(self):
""" Gets size param, the size of vectors in `inputCol`."""
self.getOrDefault(self.size)
return self.getOrDefault(self.size)

@since("2.3.0")
def setSize(self, value):
""" Sets size param, the size of vectors in `inputCol`."""
self._set(size=value)
return self._set(size=value)


if __name__ == "__main__":
Expand Down
17 changes: 17 additions & 0 deletions python/pyspark/ml/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,23 @@ def test_string_indexer_handle_invalid(self):
expected2 = [Row(id=0, indexed=0.0), Row(id=1, indexed=1.0)]
self.assertEqual(actual2, expected2)

def test_vector_size_hint(self):
df = self.spark.createDataFrame(
[(0, Vectors.dense([0.0, 10.0, 0.5])),
(1, Vectors.dense([1.0, 11.0, 0.5, 0.6])),
(2, Vectors.dense([2.0, 12.0]))],
["id", "vector"])

sizeHint = VectorSizeHint(
inputCol="vector",
handleInvalid="skip")
sizeHint.setSize(3)
self.assertEqual(sizeHint.getSize(), 3)

output = sizeHint.transform(df).head().vector
expected = DenseVector([0.0, 10.0, 0.5])
self.assertEqual(output, expected)


class HasInducedError(Params):

Expand Down