[SPARK-24208][SQL][FOLLOWUP] Move test cases to proper locations #21751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #92889 has finished for PR 21751 at commit
|
gatorsmile
reviewed
Jul 12, 2018
| assertAnalysisError(barrier, Seq("cannot resolve '`tbl.b`'")) | ||
| } | ||
|
|
||
| test("SPARK-24208: analysis fails on self-join with FlatMapGroupsInPandas") { |
Member
There was a problem hiding this comment.
please also remove the corresponding unit test case
Contributor
Author
There was a problem hiding this comment.
sorry, I forgot that, I am doing it, thanks.
|
Test build #92921 has finished for PR 21751 at commit
|
gatorsmile
reviewed
Jul 12, 2018
| } | ||
|
|
||
| test("SPARK-24208: analysis fails on self-join with FlatMapGroupsInPandas") { | ||
| val pythonUdf = PythonUDF("pyUDF", null, |
gatorsmile
reviewed
Jul 12, 2018
| StructType(Seq(StructField("a", LongType))), | ||
| Seq.empty, | ||
| PythonEvalType.SQL_GROUPED_MAP_PANDAS_UDF, | ||
| true) |
Member
There was a problem hiding this comment.
Nit: udfDeterministic = true
Member
|
Please follow the style suggestions in the future. LGTM Thanks! Merged to master |
Contributor
Author
|
sure, I'll keep them in mind. Sorry for the mistakes, I'll be more careful. Thanks @gatorsmile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The PR is a followup to move the test cases introduced by the original PR in their proper location.
How was this patch tested?
moved UTs