Skip to content

[SPARK-24348][SQL] "element_at" error fix #21395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-24348][SQL] "element_at" error fix #21395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec2e4a6
SPARK-24348 "element_at" error fix
wajda May 22, 2018
045307b
SPARK-24348 + error message check
wajda May 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...alyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1469,6 +1469,7 @@ case class ElementAt(left: Expression, right: Expression) extends GetMapValueUti
left.dataType match {
case _: ArrayType => IntegerType
case _: MapType => left.dataType.asInstanceOf[MapType].keyType
case _ => AnyDataType // no match for a wrong 'left' expression type
Copy link
Member

@gatorsmile gatorsmile May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, normally, we prefer to

  override def inputTypes: Seq[AbstractDataType] = {
    val rightInputType = left.dataType match {
      case _: ArrayType => IntegerType
      case _: MapType => left.dataType.asInstanceOf[MapType].keyType
      case _ => AnyDataType // no match for a wrong 'left' expression type
    }
    Seq(TypeCollection(ArrayType, MapType), rightInputType)
  }

}
)
}
Expand Down
6 changes: 6 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,6 +756,12 @@ class DataFrameFunctionsSuite extends QueryTest with SharedSQLContext {
df.selectExpr("element_at(a, -1)"),
Seq(Row("3"), Row(""), Row(null))
)

val e = intercept[AnalysisException] {
Seq(("a string element", 1)).toDF().selectExpr("element_at(_1, _2)")
}
assert(e.message.contains(
"argument 1 requires (array or map) type, however, '`_1`' is of string type"))
}

test("concat function - arrays") {
Expand Down