[SPARK-22948][k8s] Move SparkPodInitContainer to correct package. #20156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
liyinan926
reviewed
Jan 4, 2018
| name="kubernetes", | ||
| dependencies=[], | ||
| source_file_regexes=["resource-managers/kubernetes/core"], | ||
| source_file_regexes=["resource-managers/kubernetes"], |
Contributor
Author
There was a problem hiding this comment.
Otherwise when you change something outside of kubernetes/core (like the docker files), all unit tests will be run, not just the stuff related to k8s.
I requested this change in the original PR but you guys never addressed it.
Contributor
There was a problem hiding this comment.
Ah, sorry the comment was not caught by us.
Contributor
|
LGTM. |
|
Test build #85691 has finished for PR 20156 at commit
|
Contributor
Author
|
Merging to master / 2.3. |
asfgit
pushed a commit
that referenced
this pull request
Jan 4, 2018
Author: Marcelo Vanzin <[email protected]> Closes #20156 from vanzin/SPARK-22948. (cherry picked from commit 95f9659) Signed-off-by: Marcelo Vanzin <[email protected]>
|
Test build #85692 has finished for PR 20156 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.