Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Dec 14, 2017

What changes were proposed in this pull request?

Like Parquet, users can use ORC with Apache Spark structured streaming. This PR adds orc() to DataStreamReader(Scala/Python) in order to support creating streaming dataset with ORC file format more easily like the other file formats. Also, this adds a test coverage for ORC data source and updates the document.

BEFORE

scala> spark.readStream.schema("a int").orc("/tmp/orc_ss").writeStream.format("console").start()
<console>:24: error: value orc is not a member of org.apache.spark.sql.streaming.DataStreamReader
       spark.readStream.schema("a int").orc("/tmp/orc_ss").writeStream.format("console").start()

AFTER

scala> spark.readStream.schema("a int").orc("/tmp/orc_ss").writeStream.format("console").start()
res0: org.apache.spark.sql.streaming.StreamingQuery = org.apache.spark.sql.execution.streaming.StreamingQueryWrapper@678b3746

scala>
-------------------------------------------
Batch: 0
-------------------------------------------
+---+
|  a|
+---+
|  1|
+---+

How was this patch tested?

Pass the newly added test cases.

@SparkQA
Copy link

SparkQA commented Dec 14, 2017

Test build #84892 has finished for PR 19975 at commit 66475b7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 14, 2017

Test build #84893 has finished for PR 19975 at commit 1ab78ed.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 14, 2017

Test build #84901 has finished for PR 19975 at commit 29094cc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Hi, @tdas and @zsxwing .
Could you review this PR?

@dongjoon-hyun
Copy link
Member Author

Also, @brkyvz . Could you review this PR?

@dongjoon-hyun
Copy link
Member Author

Hi, @tdas , @zsxwing , @brkyvz .
Could you give me some advice about how to proceed this PR?

@brkyvz
Copy link
Contributor

brkyvz commented Dec 18, 2017

This LGTM. @zsxwing Any other comments?

@dongjoon-hyun
Copy link
Member Author

Thank you so much, @brkyvz !

@zsxwing
Copy link
Member

zsxwing commented Dec 18, 2017

LGTM. Let's trigger a new build since it's 5 days old now.

retest this please.

@dongjoon-hyun
Copy link
Member Author

Thank you so much, @zsxwing !

@dongjoon-hyun
Copy link
Member Author

Retest this please.

@SparkQA
Copy link

SparkQA commented Dec 19, 2017

Test build #85078 has finished for PR 19975 at commit 29094cc.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Retest this please

@SparkQA
Copy link

SparkQA commented Dec 19, 2017

Test build #85098 has finished for PR 19975 at commit 29094cc.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Retest this please

@SparkQA
Copy link

SparkQA commented Dec 19, 2017

Test build #85117 has finished for PR 19975 at commit 29094cc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Dec 19, 2017

Hi, @brkyvz and @zsxwing . It passed the Jenkins again finally.

@dongjoon-hyun
Copy link
Member Author

Gentle ping! :)

@zsxwing
Copy link
Member

zsxwing commented Dec 20, 2017

Thanks! Merging to master!

@asfgit asfgit closed this in 9962390 Dec 20, 2017
@dongjoon-hyun
Copy link
Member Author

Thank you so much, @zsxwing and @brkyvz

@dongjoon-hyun dongjoon-hyun deleted the SPARK-22781 branch December 20, 2017 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants