[SPARK-22700][ML] Bucketizer.transform incorrectly drops row containing NaN #19894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #84481 has finished for PR 19894 at commit
|
|
Test build #84485 has finished for PR 19894 at commit
|
Contributor
Author
|
ping @MLnick ? |
Contributor
|
LGTM. Good fix. |
Contributor
|
LGTM thanks! Merged to master |
Member
|
I'm going to backport this to 2.2 since it's a correctness bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
only drops the rows containing NaN in the input columns
How was this patch tested?
existing tests and added tests