-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-22551][SQL] Prevent possible 64kb compile error for common expression types #19780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #83987 has finished for PR 19780 at commit
|
|
Test build #83988 has finished for PR 19780 at commit
|
|
cc @cloud-fan @kiszk |
|
Could you add a test case? |
|
Test build #84000 has finished for PR 19780 at commit
|
|
Test build #84008 has finished for PR 19780 at commit
|
|
Test build #84009 has finished for PR 19780 at commit
|
|
I can't reproduce the issue after #19767 is merged. Hopefully it solves this issue too, so I will close this. If not and I can reproduce it later, I will re-open this. |
What changes were proposed in this pull request?
For common expression types, such as BinaryExpression and TernaryExpression, the combination of generated codes of children can possibly be large. We should put the codes into functions to prevent possible 64kb compile error.
How was this patch tested?
Added test.