Skip to content

Conversation

@jinxing64
Copy link

What changes were proposed in this pull request?

In current code, SessionState in SparkSQLCLIDriver is not guaranteed to be closed. As a result, some tmp files/dirs are not removed when job finished. We can close SessionState in shutdown hook.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it matters, but keep in mind this will hold a reference to sessionState then until the JVM exits

@SparkQA
Copy link

SparkQA commented Sep 13, 2017

Test build #81713 has finished for PR 19219 at commit 2a06c0c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jinxing64
Copy link
Author

jinxing64 commented Sep 14, 2017

@gatorsmile @HyukjinKwon
Could you please give some advice on this?

@jinxing64
Copy link
Author

It seems there are still some other places where session state is not guaranteed to be closed. I will update this pr soon.

@jinxing64 jinxing64 changed the title [SPARK-21993][SQL] Close sessionState in shutdown hook. [SPARK-21993][SQL][WIP] Close sessionState when finish Sep 16, 2017
@SparkQA
Copy link

SparkQA commented Sep 16, 2017

Test build #81838 has finished for PR 19219 at commit 1187dac.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newSession is to isolate SparkSession in Spark ThriftServer, You must judge whether is thriftserver or not.

@SparkQA
Copy link

SparkQA commented Sep 18, 2017

Test build #81874 has finished for PR 19219 at commit d7a484d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 20, 2017

Test build #81997 has finished for PR 19219 at commit df49a19.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 21, 2017

Test build #82017 has finished for PR 19219 at commit e421113.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jinxing64 jinxing64 changed the title [SPARK-21993][SQL][WIP] Close sessionState when finish [SPARK-21993][SQL] Close sessionState when finish Sep 21, 2017
@gatorsmile
Copy link
Member

cc @liufengdb

@liufengdb
Copy link

The major issue this PR tries to cover has been fixed by #20029, so I think we are good if there are no calls to HiveClientImpl.newSession. We can close this PR with no-fix.

@SparkQA
Copy link

SparkQA commented Feb 1, 2018

Test build #86911 has finished for PR 19219 at commit e421113.

  • This patch fails PySpark unit tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@srowen srowen mentioned this pull request Oct 24, 2018
@asfgit asfgit closed this in 65c653f Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants