-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-21993][SQL] Close sessionState when finish #19219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it matters, but keep in mind this will hold a reference to sessionState then until the JVM exits
|
Test build #81713 has finished for PR 19219 at commit
|
|
@gatorsmile @HyukjinKwon |
|
It seems there are still some other places where session state is not guaranteed to be closed. I will update this pr soon. |
2a06c0c to
1187dac
Compare
|
Test build #81838 has finished for PR 19219 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newSession is to isolate SparkSession in Spark ThriftServer, You must judge whether is thriftserver or not.
|
Test build #81874 has finished for PR 19219 at commit
|
d7a484d to
df49a19
Compare
|
Test build #81997 has finished for PR 19219 at commit
|
df49a19 to
e421113
Compare
|
Test build #82017 has finished for PR 19219 at commit
|
|
cc @liufengdb |
|
The major issue this PR tries to cover has been fixed by #20029, so I think we are good if there are no calls to |
|
Test build #86911 has finished for PR 19219 at commit
|
What changes were proposed in this pull request?
In current code,
SessionStateinSparkSQLCLIDriveris not guaranteed to be closed. As a result, some tmp files/dirs are not removed when job finished. We can closeSessionStatein shutdown hook.