Skip to content

Conversation

@markhamstra
Copy link
Contributor

Erik, you've been doing some great work on making non-lazy transforms lazy! I haven't had time to thoroughly review your recent PRs, but can you do some checks and probably add some tests to make sure that all of your recent efforts also work correctly not only for synchronous actions on RDDs (collect, count, et al), but also the async actions in AsyncRDDActions.scala? It looked to me like at least the RangePartitioner work, while better than what is in Spark now, still had some troubles in async actions (essentially, the production of the rangeBounds doesn't get captured within the FutureAction, so it isn't cancellable, etc.)

@erikerlandson
Copy link
Contributor Author

Good point, I will look into those.

@rxin
Copy link
Contributor

rxin commented Aug 12, 2014

@erikerlandson perhaps also create an umbrella ticket and make all the related tickets a sub-task for the umbrella one? This way it is a lot easier to track them. Cheers.

@erikerlandson
Copy link
Contributor Author

@rxin I created an umbrella:
https://issues.apache.org/jira/browse/SPARK-2992

@SparkQA
Copy link

SparkQA commented Sep 5, 2014

Can one of the admins verify this patch?

@petro-rudenko
Copy link
Contributor

+1 for this. Useful feature to calculate distributed cumulative sum.

@JoshRosen
Copy link
Contributor

Any updates on this? Will you publish this as part of Silex like you did with #1839?

@erikerlandson
Copy link
Contributor Author

@JoshRosen, yes I plan on adding this to silex in the near future. If you like I can close it.

@SparkQA
Copy link

SparkQA commented Aug 30, 2015

QA tests have started for PR 1909. This patch DID NOT merge cleanly!
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41794/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 30, 2015

QA results for PR 1909:
- This patch FAILED unit tests.

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41794/consoleFull

@erikerlandson
Copy link
Contributor Author

I migrated this PR to the 3rd party silex project:
https://github.com/willb/silex/pull/28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants