From 6e18316254081603ffb8f387de0a35c18155c0bd Mon Sep 17 00:00:00 2001 From: lishuming Date: Sat, 27 May 2017 23:01:36 +0800 Subject: [PATCH 1/2] remove no need loop in JobProgressListener --- .../org/apache/spark/ui/jobs/JobProgressListener.scala | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala b/core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala index 1b10feb36e439..3d6d22c675eb9 100644 --- a/core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala +++ b/core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala @@ -202,12 +202,12 @@ class JobProgressListener(conf: SparkConf) extends SparkListener with Logging { } jobIdToData(jobStart.jobId) = jobData activeJobs(jobStart.jobId) = jobData - for (stageId <- jobStart.stageIds) { - stageIdToActiveJobIds.getOrElseUpdate(stageId, new HashSet[StageId]).add(jobStart.jobId) - } + // If there's no information for a stage, store the StageInfo received from the scheduler // so that we can display stage descriptions for pending stages: for (stageInfo <- jobStart.stageInfos) { + stageIdToActiveJobIds.getOrElseUpdate(stageInfo.stageId, new HashSet[StageId]).add(jobStart.jobId) + stageIdToInfo.getOrElseUpdate(stageInfo.stageId, stageInfo) stageIdToData.getOrElseUpdate((stageInfo.stageId, stageInfo.attemptId), new StageUIData) } From d70c5e54d68ed5a5506977888de01e4110f6624b Mon Sep 17 00:00:00 2001 From: lishuming Date: Sat, 27 May 2017 23:12:56 +0800 Subject: [PATCH 2/2] fix new line length > 100 --- .../scala/org/apache/spark/ui/jobs/JobProgressListener.scala | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala b/core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala index 3d6d22c675eb9..f325a802dc2eb 100644 --- a/core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala +++ b/core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala @@ -206,7 +206,8 @@ class JobProgressListener(conf: SparkConf) extends SparkListener with Logging { // If there's no information for a stage, store the StageInfo received from the scheduler // so that we can display stage descriptions for pending stages: for (stageInfo <- jobStart.stageInfos) { - stageIdToActiveJobIds.getOrElseUpdate(stageInfo.stageId, new HashSet[StageId]).add(jobStart.jobId) + stageIdToActiveJobIds.getOrElseUpdate(stageInfo.stageId, + new HashSet[StageId]).add(jobStart.jobId) stageIdToInfo.getOrElseUpdate(stageInfo.stageId, stageInfo) stageIdToData.getOrElseUpdate((stageInfo.stageId, stageInfo.attemptId), new StageUIData)