From cca89c8158becf7f5fc8e89430c9f73345b41fa0 Mon Sep 17 00:00:00 2001 From: Andrew Or Date: Wed, 6 Aug 2014 13:02:58 -0700 Subject: [PATCH 1/4] Fix jenkins typo + not outputting to github --- dev/run-tests-jenkins | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/dev/run-tests-jenkins b/dev/run-tests-jenkins index 3076eb847b420..eb62ac00bd601 100755 --- a/dev/run-tests-jenkins +++ b/dev/run-tests-jenkins @@ -32,7 +32,7 @@ function post_message { echo "Attempting to post to Github:" echo "$data" - curl -D- -u x-oauth-basic:$GITHUB_OAUTH_KEY -X POST --data "$data" -H \ + curl -D- -u x-oauth-basic:$GITHUB_OAUTH_KEY -X POST --data \""$data"\" -H \ "Content-Type: application/json" \ $COMMENTS_URL | head -n 8 } @@ -69,7 +69,8 @@ if [ "$sha1" != "$ghprbActualCommit" ]; then | grep \+ \ | sed "s/\+ *//" \ | tr "\n" "~" \ - | sed "s/~/
/g") + | sed "s/~/
/g" + | sed "s/\"/\\\\\"/g") if [ "$new_public_classes" == "" ]; then result_message="$result_message- This patch adds no public classes
" else @@ -77,9 +78,13 @@ if [ "$sha1" != "$ghprbActualCommit" ]; then result_message="$result_message$new_public_classes" fi fi -result_message="${result_message}
For more information see test ouptut:" +result_message="${result_message}
For more information see test output:" result_message="${result_message}
${BUILD_URL}consoleFull" post_message "$result_message" +# TODO: For testing only, remove me before merging this PR. +# case class You(age: Int = 40, money: Long = -100, catchPhrase: String = "hey bro") +# case class Me(age: Int = 25, money: Long = 1000000, catchPhrase: String) + exit $test_result From 98932d0e73d60ed06ec920c59f2482ff1a0068da Mon Sep 17 00:00:00 2001 From: andrewor14 Date: Wed, 6 Aug 2014 16:55:34 -0700 Subject: [PATCH 2/4] Add line break so Jenkins actually runs --- dev/run-tests-jenkins | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/run-tests-jenkins b/dev/run-tests-jenkins index eb62ac00bd601..99213ff4673b5 100755 --- a/dev/run-tests-jenkins +++ b/dev/run-tests-jenkins @@ -69,7 +69,7 @@ if [ "$sha1" != "$ghprbActualCommit" ]; then | grep \+ \ | sed "s/\+ *//" \ | tr "\n" "~" \ - | sed "s/~/
/g" + | sed "s/~/
/g" \ | sed "s/\"/\\\\\"/g") if [ "$new_public_classes" == "" ]; then result_message="$result_message- This patch adds no public classes
" From c0d569b728f4223424de69745fb0c18f2b7b05d5 Mon Sep 17 00:00:00 2001 From: Andrew Or Date: Thu, 7 Aug 2014 19:21:19 -0700 Subject: [PATCH 3/4] Fix quotes --- dev/run-tests-jenkins | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/run-tests-jenkins b/dev/run-tests-jenkins index 99213ff4673b5..149f39603aaa5 100755 --- a/dev/run-tests-jenkins +++ b/dev/run-tests-jenkins @@ -32,7 +32,7 @@ function post_message { echo "Attempting to post to Github:" echo "$data" - curl -D- -u x-oauth-basic:$GITHUB_OAUTH_KEY -X POST --data \""$data"\" -H \ + curl -D- -u x-oauth-basic:$GITHUB_OAUTH_KEY -X POST --data "\"$data\"" -H \ "Content-Type: application/json" \ $COMMENTS_URL | head -n 8 } From 09dabd77914b044ac1594e320ba1bb5e1be969e2 Mon Sep 17 00:00:00 2001 From: Andrew Or Date: Thu, 7 Aug 2014 19:23:33 -0700 Subject: [PATCH 4/4] Fix backslashes --- dev/run-tests-jenkins | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/run-tests-jenkins b/dev/run-tests-jenkins index 149f39603aaa5..f3c889425ab1e 100755 --- a/dev/run-tests-jenkins +++ b/dev/run-tests-jenkins @@ -70,7 +70,7 @@ if [ "$sha1" != "$ghprbActualCommit" ]; then | sed "s/\+ *//" \ | tr "\n" "~" \ | sed "s/~/
/g" \ - | sed "s/\"/\\\\\"/g") + | sed "s/\\\"/\\\\\\\"/g") if [ "$new_public_classes" == "" ]; then result_message="$result_message- This patch adds no public classes
" else