[SPARK-19828][R][FOLLOWUP] Rename asJsonArray to as.json.array in from_json function in R #17653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @felixcheung, this simply renames it to |
|
Test build #75844 has finished for PR 17653 at commit
|
felixcheung
approved these changes
Apr 17, 2017
Member
|
merged to master. thanks |
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
…m_json function in R ## What changes were proposed in this pull request? This was suggested to be `as.json.array` at the first place in the PR to SPARK-19828 but we could not do this as the lint check emits an error for multiple dots in the variable names. After SPARK-20278, now we are able to use `multiple.dots.in.names`. `asJsonArray` in `from_json` function is still able to be changed as 2.2 is not released yet. So, this PR proposes to rename `asJsonArray` to `as.json.array`. ## How was this patch tested? Jenkins tests, local tests with `./R/run-tests.sh` and manual `./dev/lint-r`. Existing tests should cover this. Author: hyukjinkwon <[email protected]> Closes apache#17653 from HyukjinKwon/SPARK-19828-followup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This was suggested to be
as.json.arrayat the first place in the PR to SPARK-19828 but we could not do this as the lint check emits an error for multiple dots in the variable names.After SPARK-20278, now we are able to use
multiple.dots.in.names.asJsonArrayinfrom_jsonfunction is still able to be changed as 2.2 is not released yet.So, this PR proposes to rename
asJsonArraytoas.json.array.How was this patch tested?
Jenkins tests, local tests with
./R/run-tests.shand manual./dev/lint-r. Existing tests should cover this.