[SPARK-20349] [SQL] ListFunctions returns duplicate functions after using persistent functions #17646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatorsmile
commented
Apr 16, 2017
| FunctionIdentifier(f) | ||
| } | ||
| } | ||
| val functions = dbFunctions ++ loadedFunctions |
Member
Author
There was a problem hiding this comment.
The name of persistent function exists in both dbFunctions and loadedFunctions.
|
Test build #75832 has finished for PR 17646 at commit
|
Member
Author
cloud-fan
reviewed
Apr 17, 2017
| FunctionIdentifier(f, Some(dbName)) } | ||
| val loadedFunctions = | ||
| StringUtils.filterPattern(functionRegistry.listFunction(), pattern).map { f => | ||
| // In functionRegistry, function names are stored as an unquoted format. |
Contributor
There was a problem hiding this comment.
shall we use FunctionIdentifier as the key in functionRegistry?
Member
Author
There was a problem hiding this comment.
Yes. Will do it using this way in the following refactoring.
We can first fix the issue and then backport it to the previous branches.
Contributor
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Apr 17, 2017
…ing persistent functions ### What changes were proposed in this pull request? The session catalog caches some persistent functions in the `FunctionRegistry`, so there can be duplicates. Our Catalog API `listFunctions` does not handle it. It would be better if `SessionCatalog` API can de-duplciate the records, instead of doing it by each API caller. In `FunctionRegistry`, our functions are identified by the unquoted string. Thus, this PR is try to parse it using our parser interface and then de-duplicate the names. ### How was this patch tested? Added test cases. Author: Xiao Li <[email protected]> Closes #17646 from gatorsmile/showFunctions. (cherry picked from commit 01ff035) Signed-off-by: Xiao Li <[email protected]>
Member
Author
|
Thanks! Merging to master/2.1 |
asfgit
pushed a commit
that referenced
this pull request
Apr 18, 2017
…functions after using persistent functions Revert the changes of #17646 made in Branch 2.1, because it breaks the build. It needs the parser interface, but SessionCatalog in branch 2.1 does not have it. ### What changes were proposed in this pull request? The session catalog caches some persistent functions in the `FunctionRegistry`, so there can be duplicates. Our Catalog API `listFunctions` does not handle it. It would be better if `SessionCatalog` API can de-duplciate the records, instead of doing it by each API caller. In `FunctionRegistry`, our functions are identified by the unquoted string. Thus, this PR is try to parse it using our parser interface and then de-duplicate the names. ### How was this patch tested? Added test cases. Author: Xiao Li <[email protected]> Closes #17661 from gatorsmile/compilationFix17646.
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
…ing persistent functions ### What changes were proposed in this pull request? The session catalog caches some persistent functions in the `FunctionRegistry`, so there can be duplicates. Our Catalog API `listFunctions` does not handle it. It would be better if `SessionCatalog` API can de-duplciate the records, instead of doing it by each API caller. In `FunctionRegistry`, our functions are identified by the unquoted string. Thus, this PR is try to parse it using our parser interface and then de-duplicate the names. ### How was this patch tested? Added test cases. Author: Xiao Li <[email protected]> Closes apache#17646 from gatorsmile/showFunctions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The session catalog caches some persistent functions in the
FunctionRegistry, so there can be duplicates. Our Catalog APIlistFunctionsdoes not handle it.It would be better if
SessionCatalogAPI can de-duplciate the records, instead of doing it by each API caller. InFunctionRegistry, our functions are identified by the unquoted string. Thus, this PR is try to parse it using our parser interface and then de-duplicate the names.How was this patch tested?
Added test cases.