Skip to content

[SPARK-18208] [Shuffle] Executor OOM due to a growing LongArray in BytesToBytesMap #15722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[SPARK-18208] [Shuffle] Executor OOM due to a growing LongArray in BytesToBytesMap #15722

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8fa8fa4
Fix the OOM failure from this operator.
Nov 1, 2016
80fd5b3
Merge remote-tracking branch 'upstream/master' into jie_oom_fix
Nov 1, 2016
7a95697
address comments
Nov 2, 2016
073d58b
Update BytesToBytesMap.java
jiexiong Dec 1, 2016
e7ec5bf
Update BytesToBytesMap.java
jiexiong Dec 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@ public final class BytesToBytesMap extends MemoryConsumer {

private long peakMemoryUsedBytes = 0L;

private final int initialCapacity;

private final BlockManager blockManager;
private final SerializerManager serializerManager;
private volatile MapIterator destructiveIterator = null;
Expand Down Expand Up @@ -202,6 +204,7 @@ public BytesToBytesMap(
throw new IllegalArgumentException("Page size " + pageSizeBytes + " cannot exceed " +
TaskMemoryManager.MAXIMUM_PAGE_SIZE_BYTES);
}
this.initialCapacity = initialCapacity;
allocate(initialCapacity);
}

Expand Down Expand Up @@ -902,12 +905,12 @@ public LongArray getArray() {
public void reset() {
numKeys = 0;
numValues = 0;
longArray.zeroOut();

freeArray(longArray);
Copy link
Contributor

@mridulm mridulm Nov 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also remove the zeroOut() since that is not relevant anymore

Copy link
Author

@jiexiong jiexiong Nov 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I will remove it.

while (dataPages.size() > 0) {
MemoryBlock dataPage = dataPages.removeLast();
freePage(dataPage);
}
allocate(initialCapacity);
currentPage = null;
pageCursor = 0;
}
Expand Down