From 858e50d6199dcacd313c578904b4d3d45c193088 Mon Sep 17 00:00:00 2001 From: Mark Grover Date: Thu, 20 Oct 2016 14:57:34 -0700 Subject: [PATCH 1/2] [DOCS] Update docs to not suggest to package Spark before running tests. --- docs/building-spark.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/docs/building-spark.md b/docs/building-spark.md index f5acee6b9005..263111da6bed 100644 --- a/docs/building-spark.md +++ b/docs/building-spark.md @@ -217,11 +217,12 @@ For help in setting up IntelliJ IDEA or Eclipse for Spark development, and troub Tests are run by default via the [ScalaTest Maven plugin](http://www.scalatest.org/user_guide/using_the_scalatest_maven_plugin). Note that tests should not be run as root or an admin user. -Some of the tests require Spark to be packaged first, so always run `mvn package` with `-DskipTests` the first time. The following is an example of a correct (build, test) sequence: +The following is an example of a command to run the tests: - ./build/mvn -Pyarn -Phadoop-2.3 -DskipTests -Phive -Phive-thriftserver clean package ./build/mvn -Pyarn -Phadoop-2.3 -Phive -Phive-thriftserver test +Note, previously some tests required Spark to be packaged first before running them, so an explicit `mvn package` with `-DskipTests` was required before running `mvn test`. That is no longer required. + The ScalaTest plugin also supports running only a specific Scala test suite as follows: ./build/mvn -P... -Dtest=none -DwildcardSuites=org.apache.spark.repl.ReplSuite test @@ -233,11 +234,12 @@ or a Java test: ## Testing with SBT -Some of the tests require Spark to be packaged first, so always run `build/sbt package` the first time. The following is an example of a correct (build, test) sequence: +The following is an example of a command to run the tests: - ./build/sbt -Pyarn -Phadoop-2.3 -Phive -Phive-thriftserver package ./build/sbt -Pyarn -Phadoop-2.3 -Phive -Phive-thriftserver test +Note, previously some tests required Spark to be packaged first before running them, so an explicit `build/sbt package` was required the first time. That is no longer required. + To run only a specific test suite as follows: ./build/sbt -Pyarn -Phadoop-2.3 -Phive -Phive-thriftserver "test-only org.apache.spark.repl.ReplSuite" From 52d351759550fd12910be6c62a80e067c5b7d1f5 Mon Sep 17 00:00:00 2001 From: Mark Grover Date: Thu, 20 Oct 2016 15:27:33 -0700 Subject: [PATCH 2/2] Removing unnecessary notes --- docs/building-spark.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/docs/building-spark.md b/docs/building-spark.md index 263111da6bed..ebe46a42a15c 100644 --- a/docs/building-spark.md +++ b/docs/building-spark.md @@ -221,8 +221,6 @@ The following is an example of a command to run the tests: ./build/mvn -Pyarn -Phadoop-2.3 -Phive -Phive-thriftserver test -Note, previously some tests required Spark to be packaged first before running them, so an explicit `mvn package` with `-DskipTests` was required before running `mvn test`. That is no longer required. - The ScalaTest plugin also supports running only a specific Scala test suite as follows: ./build/mvn -P... -Dtest=none -DwildcardSuites=org.apache.spark.repl.ReplSuite test @@ -238,8 +236,6 @@ The following is an example of a command to run the tests: ./build/sbt -Pyarn -Phadoop-2.3 -Phive -Phive-thriftserver test -Note, previously some tests required Spark to be packaged first before running them, so an explicit `build/sbt package` was required the first time. That is no longer required. - To run only a specific test suite as follows: ./build/sbt -Pyarn -Phadoop-2.3 -Phive -Phive-thriftserver "test-only org.apache.spark.repl.ReplSuite"