From 84ad6797d22966c04f07cb71afe8369dc25cafb3 Mon Sep 17 00:00:00 2001 From: hyukjinkwon Date: Wed, 22 Jun 2016 22:13:09 +0900 Subject: [PATCH 1/2] Check modules to test correctly --- dev/run-tests.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dev/run-tests.py b/dev/run-tests.py index e42e07354c263..022f8a345adf5 100755 --- a/dev/run-tests.py +++ b/dev/run-tests.py @@ -114,9 +114,10 @@ def determine_modules_to_test(changed_modules): for module in changed_modules: modules_to_test = modules_to_test.union(determine_modules_to_test(module.dependent_modules)) # If we need to run all of the tests, then we should short-circuit and return 'root' + modules_to_test = modules_to_test.union(set(changed_modules)) if modules.root in modules_to_test: return [modules.root] - return modules_to_test.union(set(changed_modules)) + return modules_to_test def determine_tags_to_exclude(changed_modules): From 6e72652b9b32b40cccaa20eaf2f9936ec3105812 Mon Sep 17 00:00:00 2001 From: hyukjinkwon Date: Wed, 22 Jun 2016 22:17:40 +0900 Subject: [PATCH 2/2] Fix comments --- dev/run-tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/run-tests.py b/dev/run-tests.py index 022f8a345adf5..94b517d270dfd 100755 --- a/dev/run-tests.py +++ b/dev/run-tests.py @@ -113,8 +113,8 @@ def determine_modules_to_test(changed_modules): modules_to_test = set() for module in changed_modules: modules_to_test = modules_to_test.union(determine_modules_to_test(module.dependent_modules)) - # If we need to run all of the tests, then we should short-circuit and return 'root' modules_to_test = modules_to_test.union(set(changed_modules)) + # If we need to run all of the tests, then we should short-circuit and return 'root' if modules.root in modules_to_test: return [modules.root] return modules_to_test